Handle cases where job handler class does not exist or just a string in RetryPolicyInterceptor
#1025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in `RetryPolicyInterceptor` Additionally, made modifications to `getRetryPolicy` to ensure it returns `null` when the handler is not a class. This improves error handling and eliminates the risk of encountering runtime errors due to attempted operations on non-existent classes. Corresponding unit tests have been added.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1025 +/- ##
=========================================
Coverage 89.22% 89.23%
- Complexity 6192 6194 +2
=========================================
Files 816 816
Lines 17453 17456 +3
=========================================
+ Hits 15573 15576 +3
Misses 1880 1880 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additionally, made modifications to
getRetryPolicyto ensure it returnsnullwhen the handler is not a class. This improves error handling and eliminates the risk of encountering runtime errors due to attempted operations on non-existent classes. Corresponding unit tests have been added.This PR is a blocker for spiral/roadrunner-bridge#81