Merge pull request #74 from spiral/feature/assign-worker-inherit

Adds the ability to set the AssignWorker attribute not only directly on Workflow or Activity classes, but also on their parent classes.

src/Attribute/AssignWorker.php

@@ -10,7 +10,7 @@
 final class AssignWorker
 {
     public function __construct(
-        public readonly string $name
+        public readonly string $name,
     ) {
     }
 }

src/Dispatcher.php

@@ -21,7 +21,7 @@ public function __construct(
         private readonly RoadRunnerMode $mode,
         private readonly ReaderInterface $reader,
         private readonly TemporalConfig $config,
-        private readonly Container $container
+        private readonly Container $container,
     ) {
     }
 
@@ -44,7 +44,9 @@ public function serve(): void
 
         foreach ($declarations as $type => $declaration) {
             // Worker that listens on a task queue and hosts both workflow and activity implementations.
-            $worker = $registry->get($this->resolveQueueName($declaration));
+            $queueName = $this->resolveQueueName($declaration) ?? $this->config->getDefaultWorker();
+
+            $worker = $registry->get($queueName);
 
             if ($type === WorkflowInterface::class) {
                 // Workflows are stateful. So you need a type to create instances.
@@ -55,7 +57,7 @@ public function serve(): void
                 // Workflows are stateful. So you need a type to create instances.
                 $worker->registerActivity(
                     $declaration->getName(),
-                    fn(ReflectionClass $class): object => $this->container->make($class->getName())
+                    fn(ReflectionClass $class): object => $this->container->make($class->getName()),
                 );
             }
         }
@@ -64,14 +66,22 @@ public function serve(): void
         $factory->run();
     }
 
-    private function resolveQueueName(\ReflectionClass $declaration): string
+    private function resolveQueueName(\ReflectionClass $declaration): ?string
     {
         $assignWorker = $this->reader->firstClassMetadata($declaration, AssignWorker::class);
 
-        if ($assignWorker === null) {
-            return $this->config->getDefaultWorker();
+        if ($assignWorker !== null) {
+            return $assignWorker->name;
+        }
+
+        $parents = $declaration->getInterfaceNames();
+        foreach ($parents as $parent) {
+            $queueName = $this->resolveQueueName(new \ReflectionClass($parent));
+            if ($queueName !== null) {
+                return $queueName;
+            }
         }
 
-        return $assignWorker->name;
+        return null;
     }
 }

tests/src/DispatcherTest.php

@@ -12,30 +12,53 @@
 
 final class DispatcherTest extends TestCase
 {
-    public function testResolvingQueueName(): void
+    private \ReflectionMethod $method;
+    private Dispatcher $dispatcher;
+
+    protected function setUp(): void
     {
-        $dispatcher = new Dispatcher(
+        parent::setUp();
+
+        $this->dispatcher = new Dispatcher(
             RoadRunnerMode::Temporal,
             new AttributeReader(),
             new TemporalConfig(['defaultWorker' => 'foo']),
             $this->getContainer(),
         );
 
-        $ref = new \ReflectionClass($dispatcher);
-        $method = $ref->getMethod('resolveQueueName');
-        $method->setAccessible(true);
+        $ref = new \ReflectionClass($this->dispatcher);
+        $this->method = $ref->getMethod('resolveQueueName');
+        $this->method->setAccessible(true);
+    }
 
-        $queue = $method->invoke(
-            $dispatcher,
-            new \ReflectionClass(ActivityInterfaceWithAttribute::class)
+    public function testResolvingQueueNameWithAttributeOnClass(): void
+    {
+        $queue = $this->method->invoke(
+            $this->dispatcher,
+            new \ReflectionClass(ActivityInterfaceWithAttribute::class),
         );
+
         $this->assertSame('worker1', $queue);
+    }
 
-        $queue = $method->invoke(
-            $dispatcher,
-            new \ReflectionClass(ActivityInterfaceWithoutAttribute::class)
+    public function testResolvingQueueNameWithAttributeOnParentClass(): void
+    {
+        $queue = $this->method->invoke(
+            $this->dispatcher,
+            new \ReflectionClass(ActivityClass::class),
         );
-        $this->assertSame('foo', $queue);
+
+        $this->assertSame('worker1', $queue);
+    }
+
+    public function testResolvingQueueNameWithoutAttribute(): void
+    {
+        $queue = $this->method->invoke(
+            $this->dispatcher,
+            new \ReflectionClass(ActivityInterfaceWithoutAttribute::class),
+        );
+
+        $this->assertNull($queue);
     }
 }
 
@@ -48,3 +71,7 @@ interface ActivityInterfaceWithAttribute
 interface ActivityInterfaceWithoutAttribute
 {
 }
+
+class ActivityClass implements ActivityInterfaceWithAttribute
+{
+}