Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the root directory from the filename generated by Scaffolder #64

Merged
merged 2 commits into from
Oct 18, 2023

Conversation

msmakouz
Copy link
Member

No description provided.

@msmakouz msmakouz added the bug Something isn't working label Oct 17, 2023
@msmakouz msmakouz added this to the 2.x milestone Oct 17, 2023
@msmakouz msmakouz requested a review from butschster October 17, 2023 17:35
@msmakouz msmakouz self-assigned this Oct 17, 2023
@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (fdbe8f0) 42.37% compared to head (de652cf) 43.32%.

Additional details and impacted files
@@             Coverage Diff              @@
##                2.x      #64      +/-   ##
============================================
+ Coverage     42.37%   43.32%   +0.94%     
- Complexity      319      329      +10     
============================================
  Files            33       34       +1     
  Lines           977     1131     +154     
============================================
+ Hits            414      490      +76     
- Misses          563      641      +78     
Files Coverage Δ
src/Traits/InteractsWithScaffolder.php 95.34% <100.00%> (+1.59%) ⬆️

... and 27 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@msmakouz msmakouz force-pushed the bugfix/scaffolder-path branch from 44cf35b to de652cf Compare October 17, 2023 17:46
@butschster butschster merged commit 59e5600 into 2.x Oct 18, 2023
6 checks passed
@butschster butschster deleted the bugfix/scaffolder-path branch October 18, 2023 07:48
@butschster butschster restored the bugfix/scaffolder-path branch October 18, 2023 07:48
@butschster butschster deleted the bugfix/scaffolder-path branch October 18, 2023 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants