-
Notifications
You must be signed in to change notification settings - Fork 7
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
implement second bitmap, ~2x speedup for train (#21)
![image](https://github.com/user-attachments/assets/5a30710f-8025-4708-ad74-eee6dd14187b) ^ this is a sad flamegraph. `bzero` is not a fun place to be spending 60% of your time. ![image](https://github.com/user-attachments/assets/fbe55d00-d7fd-4999-83be-3d9b8e6b48b5) How did we get from one to two? 1. Avoid initializing our `counts1` and `counts1` vectors 2. Implement a second bitmap index that limits our outer-loop iterations in `optimize`. Because `counts1` and `counts2` are not initialized, we check the bitmap before all accesses This also gives us another 2x speedup on the train benchmark, which is nice
- Loading branch information
Showing
1 changed file
with
53 additions
and
8 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters