fix: search for first non-empty chunk #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonasspinner
force-pushed
the
fix-make-sample-non-empty-chunk
branch
from
532c04e to
0c47798
Compare
jonasspinner
force-pushed
the
fix-make-sample-non-empty-chunk
branch
from
0c47798 to
0e21a4c
Compare
Merged
a10y
pushed a commit
that referenced
this pull request
Sep 17, 2024
## 🤖 New release * `fsst-rs`: 0.4.1 -> 0.4.2 (✓ API compatible changes) <details><summary><i><b>Changelog</b></i></summary><p> <blockquote> ## [0.4.2](v0.4.1...v0.4.2) - 2024-09-17 ### Fixed - search for first non-empty chunk ([#35](#35)) - docs first3 ([#33](#33)) ### Other - Assertion should allow empty compression ([#36](#36)) </blockquote> </p></details> --- This PR was generated with [release-plz](https://github.com/MarcoIeni/release-plz/). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously,
line_nrwas not correctly modified in the loop, which is a bug. Additionally a TODO is resolved and there is no infinite loop if there are no non-empty lines in the sample.