-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: 35% faster decompression with less boundary check #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XiangpengHao
changed the title
35% better throughput with less boundary check
35% faster decompression with less boundary check
Oct 3, 2024
FYI @a10y |
a10y
reviewed
Oct 3, 2024
a10y
reviewed
Oct 3, 2024
Thanks @XiangpengHao ! Just two small comments (perhaps I'm being overly paranoid about |
Co-authored-by: Andrew Duffy <[email protected]>
Co-authored-by: Andrew Duffy <[email protected]>
Thanks for the review! I've updated the code and rerun the benchmark and see no perf difference (just to be sure). |
lwwmanning
changed the title
35% faster decompression with less boundary check
feat: 35% faster decompression with less boundary check
Oct 3, 2024
a10y
approved these changes
Oct 3, 2024
Merged
lwwmanning
pushed a commit
that referenced
this pull request
Oct 3, 2024
## 🤖 New release * `fsst-rs`: 0.4.2 -> 0.4.3 (✓ API compatible changes) <details><summary><i><b>Changelog</b></i></summary><p> <blockquote> ## [0.4.3](v0.4.2...v0.4.3) - 2024-10-03 ### Added - 35% faster decompression with less boundary check ([#41](#41)) ### Other - *(deps)* update rust crate curl to v0.4.47 ([#40](#40)) - *(deps)* update mozilla-actions/sccache-action action to v0.0.6 ([#38](#38)) </blockquote> </p></details> --- This PR was generated with [release-plz](https://github.com/MarcoIeni/release-plz/). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@XiangpengHao this change is now published in 0.4.3 https://crates.io/crates/fsst-rs/0.4.3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi SpiralDB devs! First of all, thank you for implementing the great FSST library!
While profiling a decompression workload, I noticed we have some unintended boundary checks that could be removed to improve decompression throughput by 35%, as shown in the
decompress
benchmark below.Removing those boundary checks requires more unsafe code, I've mannually annotated their correctness, but please double check! cc @alamb who might be interested