Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: nit in layouts/chunked/reader.rs #1926

Merged
merged 1 commit into from
Jan 13, 2025
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 3 additions & 7 deletions vortex-layout/src/layouts/chunked/reader.rs
Original file line number Diff line number Diff line change
Expand Up @@ -60,16 +60,12 @@ impl ChunkedReader {
pub(crate) async fn stats_table(&self) -> VortexResult<Option<&StatsTable>> {
self.stats_table
.get_or_try_init(async {
// The number of chunks
let mut nchunks = self.layout.nchildren();
if self.layout.metadata().is_some() {
// The final child is the statistics table.
nchunks -= 1;
}

Ok(match self.layout.metadata() {
None => None,
Some(metadata) => {
// The final child is the statistics table.
let nchunks = self.layout.nchildren() - 1;

// Figure out which stats are present
let present_stats: Arc<[Stat]> =
Arc::from(stats_from_bitset_bytes(metadata.as_ref()));
Expand Down
Loading