Stats use ScalarValues and not Scalars #2069
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ScalarValues
robert3005
force-pushed
the
rk/scalarvalues
branch
from
9c9c488 to
ab2e76c
Compare
gatesn
reviewed
Jan 25, 2025
| let encoded = match_each_integer_ptype!(array.ptype(), |$T| { | ||
| if shift == <$T>::PTYPE.bit_width() as u8 { | ||
| assert_eq!(min, Scalar::zero::<$T>(array.dtype().nullability())); | ||
| assert_eq!(min, Scalar::zero::<$T>(array.dtype().nullability()).into_value()); |
There was a problem hiding this comment.
Seems a shame to create a scalar with a DType then throw it away? Can you just do ScalarValue::from(0usize)?
| @@ -225,7 +226,7 @@ where | |||
| } | |||
|
|
|||
| impl dyn Statistics + '_ { | |||
| pub fn get_as<U: for<'a> TryFrom<&'a Scalar, Error = VortexError>>( | |||
| pub fn get_as<U: for<'a> TryFrom<&'a ScalarValue, Error = VortexError>>( | |||
There was a problem hiding this comment.
Can you add a doc string to this? Before get_as and get_as_cast had different behaviour, I think get_as will now always cast? But it's not clear with the docs.
| use crate::scalarvalue::InnerScalarValue; | ||
| use crate::ScalarValue; | ||
|
|
||
| impl<'a> TryFrom<&'a ScalarValue> for String { |
There was a problem hiding this comment.
I'm not necessarily a fan of all of these "helper" impls, given it's not that hard to do value.as_buffer().into_string() or equivalent.
Don't feel too strongly, it's just a lot of code that's not obviously used anywhere.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this leads to simpler stats api where for a scalarvalue you have to extract it as a type you desire but we seldom care about a precise dtype of a stats, where we do I have preserved the semantic and wrapped the scalarvalue back up into scalar