Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload thumbnail test & mocking #19

Merged
merged 8 commits into from
May 26, 2024
Merged

Upload thumbnail test & mocking #19

merged 8 commits into from
May 26, 2024

Conversation

sisygoboom
Copy link
Collaborator

  • create test for thumbnail uploading endpoint
  • updates to the mock factory and which modules it affects in different environments:
    no longer affects repositories as we're using a replica set in staging anyway
    no longer affects staging: ipfs and hive modules, as we need to test these in prod-like environments

Copy link
Contributor

@Geo25rey Geo25rey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why the deleted mocks?

Absolutely no binary files unless 100% necessary.

src/services/uploader/test-resources/test.png Outdated Show resolved Hide resolved
Copy link
Contributor

@Geo25rey Geo25rey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sisygoboom sisygoboom merged commit 3d24c9e into main May 26, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants