Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test and fixes for create_uploads endpoint #21

Merged
merged 14 commits into from
Jun 15, 2024
Merged

Test and fixes for create_uploads endpoint #21

merged 14 commits into from
Jun 15, 2024

Conversation

sisygoboom
Copy link
Collaborator

@sisygoboom sisygoboom commented Jun 7, 2024 •
edited
Loading

In this PR:

  • uniform method for generating document unique IDs
  • build test for creating upload method (unfortunately, e2e proved too complex to do in a reasonable amount of time due to requiring authentication and interceptor)
  • potential fix for user details interceptor
  • Typing fixes relating to schemas

Geo25rey
Geo25rey reviewed Jun 13, 2024
View reviewed changes
src/repositories/upload/upload.repository.ts Outdated Show resolved Hide resolved
src/repositories/video/video.repository.ts Outdated Show resolved Hide resolved
src/services/uploader/uploading.controller.test.ts Show resolved Hide resolved
src/services/uploader/uploading.service.ts Outdated Show resolved Hide resolved
src/services/uploader/uploading.service.ts Outdated Show resolved Hide resolved
src/services/publishing/publishing.service.ts Outdated Show resolved Hide resolved
src/services/uploader/uploading.controller.test.ts Outdated Show resolved Hide resolved
src/services/uploader/uploading.controller.ts Outdated Show resolved Hide resolved
src/services/uploader/uploading.controller.ts Outdated Show resolved Hide resolved
src/services/uploader/uploading.types.ts

export type User = z.infer<typeof userSchema>;

export type UserRequest = z.infer<typeof requestSchema>;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love the types

Geo25rey
Geo25rey reviewed Jun 14, 2024
View reviewed changes
Copy link
Contributor

@Geo25rey Geo25rey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once the rest of the convos are resolved, LGTM

Geo25rey
Geo25rey approved these changes Jun 14, 2024
View reviewed changes
Copy link
Contributor

@Geo25rey Geo25rey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sisygoboom sisygoboom merged commit 255bea5 into main Jun 15, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Geo25rey Geo25rey Geo25rey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sisygoboom @Geo25rey