Align with legacy db #31

sisygoboom · 2024-07-11T20:04:01Z

This large pr serves the purpose of aligning the code with the existing data on MongoDB. To do this I have:

aligned the schemas with what exists on mongo
ensure the correct database and collection names were used
Update code so that new users and account linking is consistent with the old data structure
Ensure tests are still working
sub is now used in the same way email address is used and a uuid I used as the main id

src/repositories/user/user.repository.ts

src/repositories/userAccount/schemas/user-account.schema.ts

src/services/api/api.contoller.test.ts

src/services/auth/auth.controller.ts

src/services/auth/auth.service.test.ts

src/services/auth/auth.service.ts

Co-authored-by: Geoffrey Casper <[email protected]>

Geo25rey · 2024-07-22T18:55:15Z

src/services/uploader/uploading.controller.ts

-    if (this.hiveChainRepository.verifyPostingAuth(accountDetails) === false) {
-      const reason = `Hive Account @${hiveUsername} has not granted posting authority to @threespeak`;
-      const errorType = 'MISSING_POSTING_AUTHORITY';
-      throw new HttpException({ reason: reason, errorType: errorType }, HttpStatus.FORBIDDEN);
-    }


This should not be removed, as this is when posting authority is required. Users should not be required to give posting authority to log in to Acela Core.

Hive chain will just throw this same error if we don't have authority, What is the point of wasting an extra request checking?

Geo25rey · 2024-07-22T19:14:54Z

src/services/hive/hive.service.ts

    sub,
  }: {
    hiveAccount: string;
-    sub: string;
+    user_id: string;
+    sub?: string;


Ah yes the tech debt. Probably fine for now, but probably should be removed in the future I think.

What do you mean? we use this further down to work out if they have authority over an account

Geo25rey · 2024-07-22T19:16:24Z

src/services/hive/hive.service.ts

    if (linkedAccount) {
      throw new HttpException({ reason: 'Hive account already linked' }, HttpStatus.BAD_REQUEST);
    }
    const hiveAccount = await this.#hiveChainRepository.getAccount(hiveUsername);
    if (!hiveAccount)
      throw new NotFoundException(`Requested hive account (${hiveAccount}) could not be found.`);
    await this.#hiveChainRepository.verifyHiveMessage(
-      `${sub} is the owner of @${hiveUsername}`,
+      `${user_id} is the owner of @${hiveUsername}`,


Does this mean we need to change the message we are signing on the frontend? What should it look like? Do you have an example?

yes, you'd have to sign with the user id, it can be found in the token and there's also a /user endpoint which exposes it

Christopher Graney-Ward added 5 commits July 11, 2024 02:04

Convert auth middleware to an interceptor for better readability

7382332

Align the data model with legacy MongoDB data structure

6e60830

Update some logging

3f4b225

Replace sub with user_id in various places

0d13e3c

Merge branch 'main' into align-with-lagacy-db

4c4a646