Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add network unit tests #186

Merged
merged 3 commits into from
Oct 18, 2024
Merged

Conversation

matt439
Copy link
Contributor

@matt439 matt439 commented Oct 4, 2024

ThothTech fork pull request: thoth-tech#73

Description

There are currently no unit tests for SplashKit's networking functions. I have created tests which cover the the creation of servers and connections, as well as the conversion functions.

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Adding the new tests was achieved by running cmake -G "Unix Makefiles" . followed by make when in the /splashkit-core/projects/cmake directory.

Testing Checklist

  • Tested with skunit_tests

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • My changes generate no new warnings

@macite macite merged commit ce4d755 into splashkit:develop Oct 18, 2024
3 checks passed
@matt439 matt439 deleted the add-network-unit-tests branch November 1, 2024 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants