Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SplitAuthenticator #564

Merged
merged 1 commit into from
Nov 29, 2023
Merged

SplitAuthenticator #564

merged 1 commit into from
Nov 29, 2023

Conversation

gthea
Copy link
Contributor

@gthea gthea commented Nov 28, 2023

Android SDK

What did you accomplish?

  • Created SplitAuthenticator related classes to eventually replace the okhttp3.Authenticator type from the proxyAuthenticator config parameter.

The SplitAuthenticator class may be extended to provide authentication logic.

@gthea gthea self-assigned this Nov 28, 2023
@gthea gthea changed the base branch from four_baseline to SDKS-7783_baseline November 28, 2023 22:05
@gthea gthea marked this pull request as ready for review November 29, 2023 00:15
@gthea gthea requested a review from a team as a code owner November 29, 2023 00:15
javrudsky
javrudsky approved these changes Nov 29, 2023
View reviewed changes
Copy link
Contributor

@javrudsky javrudsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gthea gthea merged commit faed8d9 into SDKS-7783_baseline Nov 29, 2023
@gthea gthea deleted the SDKS-7783_1 branch November 29, 2023 16:21
@gthea gthea mentioned this pull request Nov 29, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javrudsky javrudsky javrudsky approved these changes

Assignees

@gthea gthea

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gthea @javrudsky