polish

splitio · Aug 14, 2024 · 2ec4789 · 2ec4789
1 parent 4a7079a
commit 2ec4789
Showing 1 changed file with 2 additions and 10 deletions.
diff --git a/client/src/main/java/io/split/service/SplitHttpClientKerberosImpl.java b/client/src/main/java/io/split/service/SplitHttpClientKerberosImpl.java
@@ -72,7 +72,6 @@ public synchronized SplitHttpResponse get(URI uri, FetchOptions options, Map<Str
         }
     }
     public SplitHttpResponse doGet(HttpURLConnection getHttpURLConnection, FetchOptions options, Map<String, List<String>> additionalHeaders) {
-        InputStreamReader inputStreamReader = null;
         try {
             getHttpURLConnection.setRequestMethod("GET");
             setBasicHeaders(getHttpURLConnection);
@@ -100,28 +99,21 @@ public SplitHttpResponse doGet(HttpURLConnection getHttpURLConnection, FetchOpti
                 statusMessage = getHttpURLConnection.getResponseMessage();
             }
 
-            inputStreamReader = new InputStreamReader(getHttpURLConnection.getInputStream());
+            InputStreamReader inputStreamReader = new InputStreamReader(getHttpURLConnection.getInputStream());
             BufferedReader br = new BufferedReader(inputStreamReader);
             String strCurrentLine;
             StringBuilder bld = new StringBuilder();
             while ((strCurrentLine = br.readLine()) != null) {
                 bld.append(strCurrentLine);
             }
             String responseBody = bld.toString();
+            inputStreamReader.close();
             return new SplitHttpResponse(responseCode,
                     statusMessage,
                     responseBody,
                     getResponseHeaders(getHttpURLConnection));
         } catch (Exception e) {
             throw new IllegalStateException(String.format("Problem in http get operation: %s", e), e);
-        } finally {
-            try {
-                if (inputStreamReader != null) {
-                    inputStreamReader.close();
-                }
-            } catch (Exception e) {
-                _log.error(String.format("Could not close HTTP Stream: %s", e), e);
-            }
         }
     }