Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Pluggable storage] validation #598

Open
wants to merge 4 commits into
base: pluggable_storage_polishing
Choose a base branch
from
Open

[Pluggable storage] validation #598

wants to merge 4 commits into from

Conversation

EmilianoSanchez
Copy link
Contributor

@EmilianoSanchez EmilianoSanchez commented Nov 23, 2021 •
edited
Loading

JS SDK

What did you accomplish?

Added extra config validation:

  • Throws exception if no REDIS or PLUGGABLE storage is provided in consumer mode
  • Log error and fallback to MEMORY storage if REDIS or PLUGGABLE storage is provided in standalone or localhost mode

How do we test the changes introduced in this PR?

Updated unit test

Extra Notes

@EmilianoSanchez EmilianoSanchez changed the base branch from development to pluggable_storage_polishing November 23, 2021 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@EmilianoSanchez