Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle defaults of updateOnSdk props, when non boolean values are provided #219

Merged
merged 15 commits into from
Dec 4, 2024

Conversation

EmilianoSanchez
Copy link
Contributor

@EmilianoSanchez EmilianoSanchez commented Nov 5, 2024

React SDK

What did you accomplish?

  • Fixed an issue with the updateOn*** object parameters of the useSplitClient and useSplitTreatments hooks, and their components and HOCs alternatives, which were not defaulting to true when a non-boolean value was provided.

How do we test the changes introduced in this PR?

  • Updated unit tests.

Extra Notes

@EmilianoSanchez EmilianoSanchez requested a review from a team as a code owner November 5, 2024 17:05
Copy link

@EmilianoSanchez EmilianoSanchez merged commit 14e5e58 into development Dec 4, 2024
7 checks passed
@EmilianoSanchez EmilianoSanchez deleted the fix_on_update_props branch December 4, 2024 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants