Skip to content
This repository has been archived by the owner on Jan 6, 2025. It is now read-only.

Commit

Permalink
PAPP-31096, PAPP-30822: Updated requests, certifi, requests, urllib3 …
Browse files Browse the repository at this point in the history
…dependencies
  • Loading branch information
mmomin-crest committed Aug 16, 2024
1 parent 1fdf551 commit 431a6df
Show file tree
Hide file tree
Showing 14 changed files with 21 additions and 31 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/linting.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name: Linting
on: [push, pull_request]
jobs:
lint:
lint:
# Run per push for internal contributers. This isn't possible for forked pull requests,
# so we'll need to run on PR events for external contributers.
# String comparison below is case insensitive.
Expand Down
4 changes: 2 additions & 2 deletions .pre-commit-config.yaml
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
repos:
- repo: https://github.com/phantomcyber/dev-cicd-tools
rev: v1.16
rev: v1.18
hooks:
- id: org-hook
- id: package-app-dependencies
- repo: https://github.com/Yelp/detect-secrets
rev: v1.4.0
rev: v1.5.0
hooks:
- id: detect-secrets
args: ['--no-verify', '--exclude-files', '^ciscospark.json$']
2 changes: 1 addition & 1 deletion LICENSE
Original file line number Diff line number Diff line change
Expand Up @@ -198,4 +198,4 @@
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
limitations under the License.
14 changes: 1 addition & 13 deletions ciscospark.json
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
"product_version_regex": ".*",
"publisher": "Phantom",
"license": "Copyright (c) Phantom Cyber Corporation, 2018",
"app_version": "1.0.10",
"app_version": "1.0.11",
"utctime_updated": "2022-01-07T20:17:50.000000Z",
"package_name": "phantom_ciscospark",
"main_module": "ciscospark_connector.pyc",
Expand Down Expand Up @@ -474,10 +474,6 @@
"module": "beautifulsoup4",
"input_file": "wheels/beautifulsoup4-4.9.1-py2-none-any.whl"
},
{
"module": "certifi",
"input_file": "wheels/certifi-2021.10.8-py2.py3-none-any.whl"
},
{
"module": "chardet",
"input_file": "wheels/chardet-3.0.4-py2.py3-none-any.whl"
Expand All @@ -486,17 +482,9 @@
"module": "idna",
"input_file": "wheels/idna-2.10-py2.py3-none-any.whl"
},
{
"module": "requests",
"input_file": "wheels/requests-2.25.0-py2.py3-none-any.whl"
},
{
"module": "soupsieve",
"input_file": "wheels/soupsieve-1.9.6-py2.py3-none-any.whl"
},
{
"module": "urllib3",
"input_file": "wheels/urllib3-1.26.7-py2.py3-none-any.whl"
}
]
}
Expand Down
11 changes: 6 additions & 5 deletions ciscospark_connector.py
Original file line number Diff line number Diff line change
Expand Up @@ -15,15 +15,15 @@
#
#
# Phantom App imports
import phantom.app as phantom
from phantom.base_connector import BaseConnector
from phantom.action_result import ActionResult
import json

import phantom.app as phantom
# Usage of the consts file is recommended
# from ciscospark_consts import *
import requests
import json
from bs4 import BeautifulSoup
from phantom.action_result import ActionResult
from phantom.base_connector import BaseConnector


class RetVal(tuple):
Expand Down Expand Up @@ -280,9 +280,10 @@ def finalize(self):

if __name__ == '__main__':

import argparse
import sys

import pudb
import argparse

pudb.set_trace()

Expand Down
6 changes: 0 additions & 6 deletions exclude_files.txt

This file was deleted.

2 changes: 1 addition & 1 deletion logo_ciscospark.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion logo_ciscospark_dark.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
1 change: 1 addition & 0 deletions release_notes/unreleased.md
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
**Unreleased**
* Updated requests, certifi, requests, urllib3 dependencies in order to use platform packages [PAPP-31096, PAPP-30822]
1 change: 0 additions & 1 deletion requirements.txt
Original file line number Diff line number Diff line change
@@ -1,2 +1 @@
beautifulsoup4==4.9.1
requests==2.25.0
7 changes: 7 additions & 0 deletions tox.ini
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
[flake8]
max-line-length = 145
max-complexity = 28
extend-ignore = F403,E128,E126,E111,E121,E127,E731,E201,E202,F405,E722,D,W292

[isort]
line_length = 145
Binary file removed wheels/certifi-2021.10.8-py2.py3-none-any.whl
Binary file not shown.
Binary file removed wheels/requests-2.25.0-py2.py3-none-any.whl
Binary file not shown.
Binary file removed wheels/urllib3-1.26.7-py2.py3-none-any.whl
Binary file not shown.

0 comments on commit 431a6df

Please sign in to comment.