Merging next to main for release 2.6.0 #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Servicenow: PAPP-29359 Added new action - search sources * Update README.md * Adding empty commit * Minor Changes * Discarding the changes of connector and const file * Discarding the changes of connector and const file * Discarding the changes of connector and const file * Adding the changes of connector and const file * targetting static test failure * updated paginatin logic * updated copyright version and linting issues * Update README.md * empty commit * updated app version and release note * Update README.md * precommit changes * updated request params in get varaible action * updated logic for pagination * linitng changes * updated linting changes * Update README.md * updated pagination logic * Added pagination for search sources action * add verbose for search source and updated SERVICENOW_ERROR_FROM_SERVER message * Update README.md * Removed limit and page key-value from result and also add result if there is no records * Checking and breaking the loop if we got 1000 empty pages * Upodate search sources pagination logic based on pages and use sysparam_query key in get variable action based on API doc * Revert changes of get_variable action and update min_phantom_version * Update README.md * Updated min_phantom_version * Update README.md * Update example_values for search sources action * Update README.md * Update release notes * succinct the comments --------- Co-authored-by: dhwanis-crest <[email protected]> Co-authored-by: splunk-soar-connectors-admin <admin@splunksoar> Co-authored-by: mmomin-crest <[email protected]>
ishans-crest
approved these changes
Jun 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only one cloud job was failing in the sanity pipeline. I re-ran the cloud pipeline, and it has passed successfully.
Link of the manual pipeline run on the SaaS: https://cd.splunkdev.com/phantom-apps/app-tests/-/pipelines/17968044
Notes
Requirements
mainmainmain