Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Zerofox Alerts: Feature - Add modify notes #12

Merged
merged 6 commits into from
Sep 9, 2024
Merged

Zerofox Alerts: Feature - Add modify notes #12

merged 6 commits into from
Sep 9, 2024

Conversation

lderequesensS
Copy link
Contributor

@lderequesensS lderequesensS commented Aug 7, 2024 •
edited
Loading

Please ensure your pull request (PR) adheres to the following guidelines:

  • Please refer to our contributing documentation for any questions on submitting a pull request, link: Contribution Guide

Pull Request Checklist

Please check if your PR fulfills the following requirements:

  • Testing of all the changes has been performed (for bug fixes / features)
  • The manual_readme_content.md has been reviewed and added / updated if needed (for bug fixes / features)
  • Use the following format for the PR description: <App Name>: <PR Type> - <PR Description>
  • Provide release notes as part of the PR submission which describe high level points about the changes for the upcoming GA release.
  • Verify all checks are passing.
  • Do NOT use the next branch of the forked repo. Create separate feature branch for raising the PR.
  • Do NOT submit updates to dependencies unless it fixes an issue.

Pull Request Type

Please check the type of change your PR introduces:

  • New App
  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Documentation
  • Other (please describe):

Security Considerations (REQUIRED)

  • If you are exposing any endpoints using a REST handler,
    please document them in the manual_readme_content.md.
  • If this is a new connector or you are adding new actions
    • Please document in the manual_readme_content.md all methods (eg, OAuth) used to authenticate
      with the service that the connector is integrating with.
    • If any actions are unable to run on SOAR Cloud, please document this in the manual_readme_content.md.
  • Are you introducing any new cryptography modules? If yes, please elaborate their purpose:
  • Are you are accessing the file system? If yes, please verify that you are only accessing paths returned through
    the Vault API.
  • Are you are marking code to be ignored by Semgrep with nosemgrep?
    If yes, please provide justification in an additional comment next to the ignored code.

Release Notes (REQUIRED)

  • Provide release notes as part of the PR submission which describe high level points about the changes for the upcoming GA release.

What is the current behavior? (OPTIONAL)

  • Describe the current behavior that you are modifying.

What is the new behavior? (OPTIONAL)

  • Describe the behavior or changes that are being added by this PR.

Other information (OPTIONAL)

  • Any other information that is important to this PR such as screenshots of how the component looks before and after the change.

Pay close attention to (OPTIONAL)

  • Any specific code change or test case points which must be addressed/reviewed at the time of GA release.

Screenshots (if relevant)

Thanks for contributing!

@splunk-soar-connectors-bot
Copy link
Collaborator

Thank you for your submission! We have a total of 21 PRs open right now, and we are working hard on all of them! We will take a look as soon as we can.

@splunk-soar-connectors-bot
Copy link
Collaborator

@lderequesensS Static Tests results for commit ce4365c - https://drive.google.com/file/d/1m_b3BzRuy3gDarjB8OSGHHW6PcpWeu8U/view?usp=drivesdk

@splunk-soar-connectors-bot
Copy link
Collaborator

@lderequesensS Compile Tests results for commit ce4365c - https://drive.google.com/file/d/1vU-b8wT-CriNvc3ptTdXMxx8_YtJOlVp/view?usp=drivesdk

@lderequesensS lderequesensS reopened this Aug 7, 2024
@splunk-soar-connectors-bot
Copy link
Collaborator

@lderequesensS Static Tests results for commit ce4365c - https://drive.google.com/file/d/1E7lqQXFboo6uHJPKIpTwFXuJ4h6gPwMi/view?usp=drivesdk

@splunk-soar-connectors-bot
Copy link
Collaborator

@lderequesensS Compile Tests results for commit ce4365c - https://drive.google.com/file/d/1rT-nuxaoK9Xl465PFOGuQx4SI8tQb2po/view?usp=drivesdk

@lderequesensS lderequesensS force-pushed the add-modify-notes-action branch from ce4365c to f6033b8 Compare August 12, 2024 18:19
@splunk-soar-connectors-bot
Copy link
Collaborator

@lderequesensS Static Tests results for commit f6033b8 - https://drive.google.com/file/d/1hy9f3YOagiJZEGZ2sFinKeaCvQRxb5qn/view?usp=drivesdk

@splunk-soar-connectors-bot
Copy link
Collaborator

@lderequesensS Compile Tests results for commit f6033b8 - https://drive.google.com/file/d/1loOS98dlc1NU5Tnfq97Zaa7NNwwG1k40/view?usp=drivesdk

@lderequesensS lderequesensS force-pushed the add-modify-notes-action branch from f6033b8 to 27a9121 Compare August 12, 2024 18:46
@splunk-soar-connectors-bot
Copy link
Collaborator

@lderequesensS Static Tests results for commit 27a9121 - https://drive.google.com/file/d/1qCduZpm5LssrR-w9Qby0RU0YfFCFcuz7/view?usp=drivesdk

@splunk-soar-connectors-bot
Copy link
Collaborator

@lderequesensS Compile Tests results for commit 27a9121 - https://drive.google.com/file/d/1UHoXkXR03_LwERmYUeXTyu2p1IImVPIb/view?usp=drivesdk

@lderequesensS lderequesensS force-pushed the add-modify-notes-action branch from 27a9121 to 8593b81 Compare August 12, 2024 21:04
@splunk-soar-connectors-bot
Copy link
Collaborator

@lderequesensS Static Tests results for commit 8593b81 - https://drive.google.com/file/d/1ArIK9WFJ6CqrN8eWCAv-2c_CYnvBhhvA/view?usp=drivesdk

@splunk-soar-connectors-bot
Copy link
Collaborator

@lderequesensS Compile Tests results for commit 8593b81 - https://drive.google.com/file/d/129VdtXYlIwORNllikI5L8JWqq5v01HdN/view?usp=drivesdk

@DNRRomero
Copy link
Contributor

DNRRomero commented Aug 13, 2024 •
edited
Loading

@lderequesensS you can set the PR as ready for review

@lderequesensS lderequesensS marked this pull request as ready for review August 13, 2024 15:04
@lderequesensS lderequesensS changed the title Add modify notes action Zerofox Alerts: Feature - Add modify notes Aug 13, 2024
@lderequesensS lderequesensS force-pushed the add-modify-notes-action branch from 8593b81 to f1bdecc Compare August 13, 2024 17:23
@splunk-soar-connectors-bot
Copy link
Collaborator

@lderequesensS Static Tests results for commit f1bdecc - https://drive.google.com/file/d/1v5MUbIje952jXU3vowmXsPou-B7Tnd3c/view?usp=drivesdk

@splunk-soar-connectors-bot
Copy link
Collaborator

@lderequesensS Compile Tests results for commit f1bdecc - https://drive.google.com/file/d/152YSQCCSNeX9aj6Lzva4ia3uoC0elBrM/view?usp=drivesdk

@gdelavadiya-crest
Copy link
Contributor

Hi @lderequesensS.
We are not able to push changes to this repository. Seems like a permission issue. Could please look into this issue from your end?

@lderequesensS
Copy link
Contributor Author

Hi @gdelavadiya-crest, you should have write access now, try again.

@splunk-soar-connectors-bot
Copy link
Collaborator

@gdelavadiya-crest Static Tests results for commit 58f5302 - https://drive.google.com/file/d/1Vf2NR3vhq_WaKe2MSNCOLokZn6a_R19Y/view?usp=drivesdk

@splunk-soar-connectors-bot
Copy link
Collaborator

@gdelavadiya-crest Compile Tests results for commit 58f5302 - https://drive.google.com/file/d/17yhHW2e5RiYLa4gZX-uXk9M3WSVJtiIU/view?usp=drivesdk

@splunk-soar-connectors-bot
Copy link
Collaborator

@gdelavadiya-crest Static Tests results for commit f3903a2 - https://drive.google.com/file/d/1ihYtxZiQX7RXhZxDjMNzB9CGwrs7TQHX/view?usp=drivesdk

@splunk-soar-connectors-bot
Copy link
Collaborator

@gdelavadiya-crest Compile Tests results for commit f3903a2 - https://drive.google.com/file/d/1L_lYKwHOmlDQiNQaO9Mjgg9w56pKnged/view?usp=drivesdk

@splunk-soar-connectors-bot
Copy link
Collaborator

@gdelavadiya-crest Static Tests results for commit 4e23cd3 - https://drive.google.com/file/d/12HSNfR29Vm-Gn-i8DzRNRD8yk-6crnG4/view?usp=drivesdk

@splunk-soar-connectors-bot
Copy link
Collaborator

@gdelavadiya-crest Compile Tests results for commit 4e23cd3 - https://drive.google.com/file/d/1joYuMikm3jfAZWKEwg95sUG6sy9qyqMZ/view?usp=drivesdk

@splunk-soar-connectors-bot
Copy link
Collaborator

@gdelavadiya-crest Static Tests results for commit b6b61b1 - https://drive.google.com/file/d/1ZMZXfOO4wjBGRhZUatvRiuQqbCITaFGr/view?usp=drivesdk

@splunk-soar-connectors-bot
Copy link
Collaborator

@gdelavadiya-crest Compile Tests results for commit b6b61b1 - https://drive.google.com/file/d/157Y5agKLdUnQiJoF7Epdw2R6uadAlBGS/view?usp=drivesdk

@DNRRomero
Copy link
Contributor

Hi @stutib-crest @mmomin-crest is there anything left in this PR before merge?

@splunk-soar-connectors-bot
Copy link
Collaborator

@gdelavadiya-crest Static Tests results for commit b6b61b1 - https://drive.google.com/file/d/1F1PafhFOyduyjVUJayQMrjfl65Fgz5zF/view?usp=drivesdk

@splunk-soar-connectors-bot
Copy link
Collaborator

@gdelavadiya-crest Static Tests results for commit b6b61b1 - https://drive.google.com/file/d/1-8Zgn2KP9g1np6KneBU9ZfnKvymT9KBi/view?usp=drivesdk

@gdelavadiya-crest gdelavadiya-crest merged commit 8fc2588 into splunk-soar-connectors:next Sep 9, 2024
3 of 4 checks passed
@gdelavadiya-crest gdelavadiya-crest deleted the add-modify-notes-action branch September 9, 2024 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stutib-crest stutib-crest stutib-crest approved these changes

@mmomin-crest mmomin-crest mmomin-crest approved these changes

Assignees
No one assigned
Labels
developer-supported external-contributor PAPP-34482
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@lderequesensS @splunk-soar-connectors-bot @DNRRomero @gdelavadiya-crest @mmomin-crest @stutib-crest @ishans-crest