Feature: Improved detector validation #538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #538 +/- ##
==========================================
- Coverage 96.28% 94.43% -1.86%
==========================================
Files 34 34
Lines 1778 1832 +54
==========================================
+ Hits 1712 1730 +18
- Misses 49 85 +36
Partials 17 17 ☔ View full report in Codecov by Sentry. |
atoulme
reviewed
Oct 24, 2024
MovieStoreGuy
force-pushed
the
msg/detector-validate-func
branch
from
f7c66cb
to
3fedecf
Compare
Co-authored-by: Antoine Toulme <[email protected]>
atoulme
approved these changes
Oct 24, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This brings over the context from the existing detector solution and making sure there is coverage for it.
Changes