Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(storybook): waitForPageReady for CI #1554

Merged
merged 6 commits into from
Jan 30, 2025
Merged

chore(storybook): waitForPageReady for CI #1554

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
548f747
chore(storybook): fix wait fonts to load before taking screenshot
vtsvetkov-splunk Jan 28, 2025
f348d75
add banner
vtsvetkov-splunk Jan 28, 2025
2678570
move waiting response
vtsvetkov-splunk Jan 28, 2025
91ffc7a
more logs
vtsvetkov-splunk Jan 28, 2025
a01010d
less logs
vtsvetkov-splunk Jan 28, 2025
da84e12
Merge branch 'develop' into feature/storbyook-wait-fonts
vtsvetkov-splunk Jan 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions ui/.storybook/preview-head.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
<!--
~ Copyright 2025 Splunk Inc.
~
~ Licensed under the Apache License, Version 2.0 (the "License");
~ you may not use this file except in compliance with the License.
~ You may obtain a copy of the License at
~
~ http://www.apache.org/licenses/LICENSE-2.0
~
~ Unless required by applicable law or agreed to in writing, software
~ distributed under the License is distributed on an "AS IS" BASIS,
~ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
~ See the License for the specific language governing permissions and
~ limitations under the License.
~
-->

<link rel="preload" as="font" type="font/woff" href="/fonts/splunkdatasansmono-regular.woff" />
<link rel="preload" as="font" type="font/woff" href="/fonts/splunkdatasans-bold.woff" />
<link rel="preload" as="font" type="font/woff" href="/fonts/splunkdatasans-medium.woff" />
<link rel="preload" as="font" type="font/woff" href="/fonts/splunkdatasans-regular.woff" />
11 changes: 8 additions & 3 deletions ui/.storybook/test-runner.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { getStoryContext, TestRunnerConfig } from '@storybook/test-runner';
import { getStoryContext, TestRunnerConfig, waitForPageReady } from '@storybook/test-runner';
import { toMatchImageSnapshot } from 'jest-image-snapshot';

const config: TestRunnerConfig = {
Expand Down Expand Up @@ -38,8 +38,13 @@ const config: TestRunnerConfig = {
const customReceivedDir = `${process.cwd()}/test-reports/visual/image_snapshot_received/`;

// can't use waitForPageReady because networkidle never fires due to HMR for locally running Storybook
await page.waitForLoadState('domcontentloaded');
await page.waitForLoadState('load');
if (process.env.CI) {
await waitForPageReady(page);
} else {
await page.waitForLoadState('domcontentloaded');
await page.waitForLoadState('load');
}

await page.evaluate(() => document.fonts.ready);

const image = await page.screenshot({ animations: 'disabled', scale: 'css' });
Expand Down
Loading