Skip to content
This repository has been archived by the owner on May 10, 2018. It is now read-only.

fix for https://github.com/splunk/splunk-sdk-ruby/issues/28 #44

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

fornellas
Copy link

This should raise exceptions when error / fatal messages are sent by the API.

@shakeelmohamed
Copy link
Contributor

Hi @fornellas,

Thanks for doing this work, and submitting the contributor agreement!
Can you make a new PR against the develop branch?
If possible, can you write a test to reproduce the issue from #28?

@fornellas
Copy link
Author

Did you review the code? Would this be the best solution? If so, I'll try to write some tests.

@shakeelmohamed
Copy link
Contributor

@fornellas The changes look reasonable, tests would be even better! We won't merge directly into the master branch though, so you will need to make a new PR.

@itay
Copy link
Contributor

itay commented Nov 21, 2015

@fornellas thanks for submitting this. Would you mind:

  1. Rebasing your branch against develop
  2. Adding tests
  3. Changing the PR to target develop

@TigerWolf
Copy link

Any progress on this?

@fornellas
Copy link
Author

I have not had time to learn Test::Unit and build a proper test, I solved my issue here by monkey patching the solution in my application code for now.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants