support focus rect in shadow dom #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
First step toward supporting Shadow DOM.
…tion Adds: - MergeStylesRootContext to act as a "global" context for tracking style sheets. This should better enable multi-window scenarios and widgets. - MergeStylesShadowRootContext to act as a proxy for the shadow root.
spmonahan
approved these changes
Aug 14, 2023
brwai
commented
Aug 14, 2023
packages/utilities/src/shadowDom/MergeStylesShadowRootContext.tsx
Outdated
Show resolved
Hide resolved
…ntation (microsoft#28906) * feat: update mergeStyles to support shadow DOM NOTE: this is stil a work in progress. - Refactors Stylesheet.ts to support shadow DOM - Adds React context and hooks for opting in to shadow DOM - Adds an API for projecting styles to child windows. * refactor and docs - Refactors stylesheet shadow DOM implementation a bit. - Adds a new docs page. * refactor to clean up types - Fixes various Typescript errors - Adds APIs to better encapsulate shadow DOM features * change files * add pipeline trigger * update test * fix typescript error * improve 'ShadowConfig' check * export ShadowConfig type * add constant for '__global__' * add default ShadowConfig * remove commented out line * better change file messages * remove IStyleSheetKey type * clean up * fix import path * add null checks before inserting styles * remove commented out code * refactor IStyleOptions to optionally include shadowConfig Adds an optional `shadowConfig` object to IStyleOptions. This allows us to pass the shadow DOM configuration object through to all the places we need it without modifying APIs to add a parameter for "shadowConfig". Aligns naming. Previously we had a type `ShadowConfig` and mostly referred to objects as "shadowConfig" but there were some instances of "shadowDom". Everything is now referred to by "shadowConfig/ShadowConfig". * update styleToClassName tests * update customizable tests * update component types for shadow DOM - remove "shadowDom" prop - update syles types to include "__shadowConfig__" key * remove unused variable * fix types in shadow dom example * add guard to calling requestAnimationFrame in Stylesheet This fix is for ssr-tests.
brwai
changed the base branch from
constructible-stylesheets/merge-styles
to
shadow-dom
* add Announce context * changefile * Update packages/react-components/react-shared-contexts/src/AnnounceContext/AnnounceContext.ts Co-authored-by: Sarah Higley <[email protected]> * options fixes * updated api * Update packages/react-components/react-shared-contexts/src/AnnounceContext/AnnounceContext.ts Co-authored-by: ling1726 <[email protected]> * remove generic type --------- Co-authored-by: Sarah Higley <[email protected]> Co-authored-by: ling1726 <[email protected]>
…imum (microsoft#28689) * fix * f * test * clean test * type test
* feat(FluentProvider): emit errors on duplicate IDs * rework to properly work in SSR * Update apps/public-docsite-v9/src/Concepts/AdvancedConfiguration.stories.mdx Co-authored-by: ling1726 <[email protected]> --------- Co-authored-by: ling1726 <[email protected]>
* Fixing re-render issue for area chart * Area chart re-render fix * Fixing re-rendering for GVBC, HBC, Donut and HeatMap * Fixing the re-render issue for other charts * Change file * Updating snapshots * Resolving build error * Updating the charts to reduce re-renders * Fixing build errors * Merging master and updating snapshots * Updating snapshots * Update test * Fixing build and test errors * Fixing build and test errors * Fixing build errors * Fixing test error * Removing the test causing error * Resolving sankey chart test error * Fixing Sankey chart test failures * Fixing errors in line chart tests * Fixing errors * Fixing test errors * Removing 2 tests * Resolving donut test issue * Removing tests using act in donut chart * Resetting ids for donut test fix * Deleting tests causing test errors in PR build * Updating the charts for empty scenario * Removing tests that are failing the tests * Resolving PR comments * Heatmap test update * Sparkline test update
…#28698) * Revert "fix(react-menu): use outline for menuItem focus ring (microsoft#28685)" This reverts commit 9250428. * chg
* Adding component test plans for stacked bar chart * Change file * Adding few more tests
…ntation (microsoft#28906) * feat: update mergeStyles to support shadow DOM NOTE: this is stil a work in progress. - Refactors Stylesheet.ts to support shadow DOM - Adds React context and hooks for opting in to shadow DOM - Adds an API for projecting styles to child windows. * refactor and docs - Refactors stylesheet shadow DOM implementation a bit. - Adds a new docs page. * refactor to clean up types - Fixes various Typescript errors - Adds APIs to better encapsulate shadow DOM features * change files * add pipeline trigger * update test * fix typescript error * improve 'ShadowConfig' check * export ShadowConfig type * add constant for '__global__' * add default ShadowConfig * remove commented out line * better change file messages * remove IStyleSheetKey type * clean up * fix import path * add null checks before inserting styles * remove commented out code * refactor IStyleOptions to optionally include shadowConfig Adds an optional `shadowConfig` object to IStyleOptions. This allows us to pass the shadow DOM configuration object through to all the places we need it without modifying APIs to add a parameter for "shadowConfig". Aligns naming. Previously we had a type `ShadowConfig` and mostly referred to objects as "shadowConfig" but there were some instances of "shadowDom". Everything is now referred to by "shadowConfig/ShadowConfig". * update styleToClassName tests * update customizable tests * update component types for shadow DOM - remove "shadowDom" prop - update syles types to include "__shadowConfig__" key * remove unused variable * fix types in shadow dom example * add guard to calling requestAnimationFrame in Stylesheet This fix is for ssr-tests.
spmonahan
force-pushed
the
shadow-dom
branch
from
8f71268 to
9e7a3f9
Compare
spmonahan
force-pushed
the
shadow-dom
branch
4 times, most recently
from
2890dcd to
08dcdbe
Compare
spmonahan
force-pushed
the
shadow-dom
branch
from
d6be7fe to
9675a27
Compare
spmonahan
force-pushed
the
shadow-dom
branch
from
9675a27 to
9c83a03
Compare
spmonahan
force-pushed
the
shadow-dom
branch
from
bfeda46 to
bef87a1
Compare
spmonahan
pushed a commit
that referenced
this pull request
Jan 4, 2024
spmonahan
force-pushed
the
shadow-dom
branch
2 times, most recently
from
baebd76 to
2cb8e6e
Compare
spmonahan
force-pushed
the
shadow-dom
branch
2 times, most recently
from
fd86df2 to
a69b410
Compare
spmonahan
force-pushed
the
shadow-dom
branch
3 times, most recently
from
268bd0a to
3a804d8
Compare
spmonahan
force-pushed
the
shadow-dom
branch
2 times, most recently
from
6d48e20 to
7386d73
Compare
spmonahan
force-pushed
the
shadow-dom
branch
2 times, most recently
from
bada8e6 to
a994c4e
Compare
spmonahan
force-pushed
the
shadow-dom
branch
2 times, most recently
from
a854381 to
802ffdd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous Behavior
Focus rect styles are not applied to Fluent components within shadow doms
New Behavior
Added FocusRectProvider within MergeStylesShadowRootProvider.
Screen.Recording.2023-08-14.at.15.22.56.mov
Related Issue(s)
microsoft#28061