Skip to content

Conversation

dhruvsol
Copy link
Contributor

@dhruvsol dhruvsol commented Sep 6, 2025

Previously, the thread was set to wait for a fixed duration of 32 seconds, which is not ideal.
This change updates the behavior to wait dynamically based on the commitment level provided through the CLI.

@zfedoran
Copy link
Collaborator

zfedoran commented Sep 6, 2025

@Nagaprasadvr thoughts on this?

lgtm

@Nagaprasadvr
Copy link
Contributor

Nagaprasadvr commented Sep 7, 2025

@Nagaprasadvr thoughts on this?

lgtm

Was thinking if we can collect all signatures and check them if they got confirmed

@dhruvsol
Copy link
Contributor Author

dhruvsol commented Sep 7, 2025

What happens if one chunk of the transaction fails to write? Does the whole write fail?

@Nagaprasadvr thoughts on this?
lgtm

Was thinking if we can collect all signatures and check them if they got confirmed concurrently? And then have a count based upon that we can implement the wait logic?

@Nagaprasadvr
Copy link
Contributor

Nagaprasadvr commented Sep 7, 2025

What happens if one chunk of the transaction fails to write? Does the whole write fail?

@Nagaprasadvr thoughts on this?
lgtm

Was thinking if we can collect all signatures and check them if they got confirmed concurrently? And then have a count based upon that we can implement the wait logic?

There's a retry logic for writing segments but we have to just return if any of the writes fail and skip finalization

2 approaches we have

  1. We use retry_send_and_confirm
  2. we just do retry_send and then collect all signatures and then confirm all of them using
    https://solana.com/docs/rpc/http/getsignaturestatuses

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants