[Feat/#103] 신고하기 페이지 대략적인 UI 마무리 #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
…i-finish # Conflicts: # app/src/main/java/com/spoony/spoony/presentation/main/MainNavigator.kt
chattymin
requested changes
Jan 21, 2025
Comment on lines
85
to
94
| var reportSuccessDialogVisibility by remember { mutableStateOf(false) } | ||
|
|
||
| if (reportSuccessDialogVisibility) { | ||
| ReportCompleteDialog( | ||
| onClick = onConfirmButton, | ||
| onDismiss = { | ||
| reportSuccessDialogVisibility = false | ||
| } | ||
| ) | ||
| } |
There was a problem hiding this comment.
p3) 저는 Dialog가 Screen이 아니라고 생각해요.
해당 화면에서의 state가 변경되어 화면 전환 없이 내부 요소가 바뀌는게 Screen이라고 생각해서 저는 Dialog를 Route에 두는 편이에요. 어떻게 생각하시나요?? @Roel4990 @Hyobeen-Park @angryPodo
There was a problem hiding this comment.
p1) onConfirmButton에도 reportSuccessDialogVisibility = false 코드를 작성해주세요!
화면이 이동되는데 dialog가 남아있으니 어색합니다.
또한 onDismiss일 때에는 화면 이동을 하지 않아도 괜찮나요??
이 부분은 명세 확인 부탁드려요 :)
There was a problem hiding this comment.
- 생각해봤는데 제 생각에도 Dialog 는 Screen 에서 Route 로 빼두는게 깔끔할 것 같습니다! 해당 방식대로 수정했습니다 확인 부탁드려요!
- 명세서 확인해보니 백드롭 불가라 일단 onDismiss 부분 제외했습니다. onConfirmButton 에 reportSuccessDialogVisibility = false 추가완료했습니다 감사합니다!
There was a problem hiding this comment.
저도 동의합니다. 저는 레이어를 생각하고, 현재 스크린 위에 그려진다고 보면 더 명확한 것 같아요.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue 🛠
Work Description ✏️
Screenshot 📸
report.mp4
To Reviewers 📢