Feat: added on_court parameter to nba_pbp() and nba_pbps() func…

…tions
sportsdataverse · Nov 25, 2023 · 8e217ec · 8e217ec
1 parent 82674d7
commit 8e217ec
Show file tree

Hide file tree

Showing 5 changed files with 14 additions and 6 deletions.
diff --git a/R/nba_stats_pbp.R b/R/nba_stats_pbp.R
@@ -134,7 +134,7 @@ NULL
         tmp_gameid <- pbp_data$game_id[1]
       }
 
-      tmp_data <- hoopR::nba_boxscoretraditionalv2(game_id = tmp_gameid, start_period = x, end_period = x, range_type = 1)$PlayerStats
+      tmp_data <- nba_boxscoretraditionalv2(game_id = tmp_gameid, start_period = x, end_period = x, range_type = 1)$PlayerStats
 
       all_id <- as.integer(tmp_data$PLAYER_ID)
 
@@ -276,7 +276,7 @@ NULL
 #' ```
 nba_pbp <- function(
     game_id,
-    on_court = FALSE,
+    on_court = TRUE,
     version = "v2",
     p,
     ...){
@@ -467,7 +467,7 @@ NULL
 #' ```
 nba_pbps <- function(
     game_ids = NULL,
-    on_court = FALSE,
+    on_court = TRUE,
     version = "v2",
     nest_data = FALSE,
     ...) {

diff --git a/R/utils.R b/R/utils.R
@@ -175,7 +175,7 @@ custom_mode <- function(x, na.rm = TRUE) {
 #' @export
 most_recent_mbb_season <- function() {
   ifelse(
-    as.double(substr(Sys.Date(), 6, 7)) >= 10,
+    as.double(substr(Sys.Date(), 6, 7)) > 10,
     as.double(substr(Sys.Date(), 1, 4)) + 1,
     as.double(substr(Sys.Date(), 1, 4))
   )

diff --git a/man/dot-players_on_court.Rd b/man/dot-players_on_court.Rd
diff --git a/man/nba_pbp.Rd b/man/nba_pbp.Rd
diff --git a/man/nba_pbps.Rd b/man/nba_pbps.Rd