Skip to content

Commit

Permalink
Mark unvcrable tests that still need network
Browse files Browse the repository at this point in the history
This is necessary to allow testing with --block-network -- just pass -m
'not novcr' as well to disable these tests.

Tests affected:

- tests/utils/test_ffmpeg.py::test_download_ffmpeg

  However, I doubt whether this function is even necessary -- shouldn't
  we be providing binaries with ffmpeg bundled instead for those users
  who can't install it conveniently on their machines?
  • Loading branch information
hseg committed Aug 27, 2024
1 parent 1b26207 commit 354271a
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 0 deletions.
3 changes: 3 additions & 0 deletions pytest.ini
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
[pytest]
markers =
novcr: tests whose network traffic can't be cached
3 changes: 3 additions & 0 deletions tests/utils/test_ffmpeg.py
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,9 @@ def test_get_local_ffmpeg(monkeypatch):
assert str(local_ffmpeg).endswith("ffmpeg.exe")


# This can't be run with pytest --block-network without writing a 110M cassette
# effectively containing the entire ffmpeg binary.
@pytest.mark.novcr
def test_download_ffmpeg(monkeypatch, tmpdir):
"""
Test download_ffmpeg function.
Expand Down

0 comments on commit 354271a

Please sign in to comment.