Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue #2173 #2175

Merged
merged 5 commits into from
Sep 6, 2024
Merged

Fixed issue #2173 #2175

merged 5 commits into from
Sep 6, 2024

Conversation

R0GUE-A5H
Copy link
Contributor

@R0GUE-A5H R0GUE-A5H commented Aug 28, 2024

Title

Fixed issue #2173
run spotdl-4.2.7-win32.exe but show 404

Description

  • Edited web.py to handle the download of web app files and create a dist folder when using a cached web app.

  • Improved error handling: when no web app files are present, the script now opens localhost:8080 and returns a {'details': 'not found'} response instead of failing silently.

  • Enhanced test_matching.py to gracefully handle AssertionError exceptions.

  • Verified that everything works by testing the .exe file with an internet connection, confirming that the Web UI opens as expected.

Related Issue

Issue #2173

Motivation and Context

It solved showing of Error 404 in WEB UI app. Thus, improving the user experience and ensuring the application functions as intended.

How Has This Been Tested?

By running pytest in tests folder

Screenshots (if appropriate)

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have read the CONTRIBUTING document
  • I have read the CORE VALUES document
  • I have added tests to cover my changes
  • All new and existing tests passed

spotify-downloader Outdated Show resolved Hide resolved
@2-Buckets
Copy link

Has this issue been fixed in the public release? I'm currently experiencing the same issue after downloading and running 4.2.7.

@xnetcat
Copy link
Member

xnetcat commented Sep 2, 2024

Has this issue been fixed in the public release? I'm currently experiencing the same issue after downloading and running 4.2.7.

Not yet, try following these steps #2177 (comment)

@Smoodie7
Copy link

Smoodie7 commented Sep 4, 2024

I have this issue here even after up/downgrading python version.

@R0GUE-A5H R0GUE-A5H requested a review from xnetcat September 5, 2024 14:48
@xnetcat xnetcat changed the base branch from master to dev September 6, 2024 08:08
@xnetcat xnetcat merged commit 33cda6b into spotDL:dev Sep 6, 2024
0 of 11 checks passed
@R0GUE-A5H R0GUE-A5H deleted the web/bug-fix branch September 8, 2024 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants