Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix m3u file creation, with correct metadata generation #2258

Open
wants to merge 11 commits into
base: dev
Choose a base branch
from

Conversation

Silverarmor
Copy link
Member

@Silverarmor Silverarmor commented Dec 9, 2024

Title

Fix m3u file creation, with correct metadata generation

Description

Related Issue

#2251
#2246

Motivation and Context

How Has This Been Tested?

Update m3u_test file.
Ran pylint, black and mypy and edited as required.

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@Silverarmor Silverarmor requested review from xnetcat and PranjalSurana and removed request for xnetcat December 9, 2024 08:47
@kalalannn
Copy link

Hello, have a specific case here. I am using spotdl with termux on android. Will this case work?

~/.../Music/Test $ pwd
/data/data/com.termux/files/home/storage/shared/MP3/Music/Test

~/.../Music/Test $ spotdl --bitrate 320k --threads 4 --m3u test.m3u 'https://open.spotify.com/playlist/...'
Processing query: https://open.spotify.com/playlist/...
Found 3 songs in Test playlist (Playlist)
Skipping Artist - Song1 (file already exists) (duplicate)
Skipping Artist - Song2 (file already exists) (duplicate)
Skipping Artist- Song3 (file already exists) (duplicate)

# Created .m3u output
~/.../Music/Test $ cat test.m3u
#EXTINF:177, Artist - Song1.mp3
#EXTINF:159, Artist - Song2.mp3
#EXTINF:142, Artist - Song3.mp3

# Wanted .m3u output
~/.../Music/Test $ cat wanted.m3u
#EXTM3U
#EXTINF:177, Artist - Song1.mp3
MP3/Music/Test/Artist - Song1.mp3
#EXTINF:159, Artist - Song2.mp3
MP3/Music/Test/Artist - Song2.mp3
#EXTINF:142, Artist - Song3.mp3
MP3/Music/Test/Artist - Song3.mp3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants