fix: bump openfeature sdks

bump the openfeature sdks and remove workaround that is fixed closes #5
spotify · Aug 29, 2023 · 0d01b77 · 0d01b77
1 parent fe65155
commit 0d01b77
Show file tree

Hide file tree

Showing 7 changed files with 16 additions and 20 deletions.
diff --git a/package.json b/package.json
@@ -25,8 +25,8 @@
     "@commitlint/config-conventional": "^17.6.7",
     "@commitlint/cz-commitlint": "^17.6.7",
     "@commitlint/prompt-cli": "^17.6.7",
-    "@openfeature/js-sdk": "^1.3.3",
-    "@openfeature/web-sdk": "^0.3.10-experimental",
+    "@openfeature/js-sdk": "^1.4.2",
+    "@openfeature/web-sdk": "^0.4.0",
     "@spotify/eslint-config-base": "^15.0.0",
     "@spotify/eslint-config-react": "^15.0.0",
     "@spotify/eslint-config-typescript": "^15.0.0",

diff --git a/packages/integration-react/package.json b/packages/integration-react/package.json
@@ -5,7 +5,7 @@
   "module": "build/esm/index.js",
   "types": "build/types/index.d.ts",
   "peerDependencies": {
-    "@openfeature/web-sdk": "^0.3.10-experimental",
+    "@openfeature/web-sdk": "^0.4.0",
     "react-dom": ">=16 <19"
   },
   "scripts": {

diff --git a/packages/openfeature-server-provider/package.json b/packages/openfeature-server-provider/package.json
@@ -10,7 +10,7 @@
     "fast-deep-equal": "^3.1.3"
   },
   "peerDependencies": {
-    "@openfeature/js-sdk": "^1.3.3"
+    "@openfeature/js-sdk": "^1.4.2"
   },
   "scripts": {
     "build:esm": "tsc -p tsconfig.esm.json",

diff --git a/packages/openfeature-web-provider/package.json b/packages/openfeature-web-provider/package.json
@@ -10,7 +10,7 @@
     "fast-deep-equal": "^3.1.3"
   },
   "peerDependencies": {
-    "@openfeature/web-sdk": "^0.3.10-experimental"
+    "@openfeature/web-sdk": "^0.4.0"
   },
   "scripts": {
     "build:esm": "tsc -p tsconfig.esm.json",

diff --git a/packages/openfeature-web-provider/src/ConfidenceWebProvider.test.ts b/packages/openfeature-web-provider/src/ConfidenceWebProvider.test.ts
@@ -721,7 +721,7 @@ describe('events', () => {
     await initPromise;
     await openFeatureAPI.setContext({ targetingKey: 'user-a', name: 'Kurt' });
 
-    expect(readyHandler).toHaveBeenCalledTimes(3);
+    expect(readyHandler).toHaveBeenCalledTimes(2);
     expect(staleHandler).toHaveBeenCalledTimes(1);
     expect(errorHandler).toHaveBeenCalledTimes(0);
   });
@@ -738,6 +738,6 @@ describe('events', () => {
 
     expect(readyHandler).toHaveBeenCalledTimes(0);
     expect(staleHandler).toHaveBeenCalledTimes(1);
-    expect(errorHandler).toHaveBeenCalledTimes(3);
+    expect(errorHandler).toHaveBeenCalledTimes(2);
   });
 });
diff --git a/packages/openfeature-web-provider/src/ConfidenceWebProvider.ts b/packages/openfeature-web-provider/src/ConfidenceWebProvider.ts
@@ -42,13 +42,9 @@ export class ConfidenceWebProvider implements Provider {
         flags: [],
       });
       this.status = ProviderStatus.READY;
-      // this event should be emitted by the OpenFeature sdk onto the client handlers, but in current version is not work.
-      this.events.emit(ProviderEvents.Ready);
       return Promise.resolve();
     } catch (e) {
       this.status = ProviderStatus.ERROR;
-      // this event should be emitted by the OpenFeature sdk onto the client handlers, but in current version is not work.
-      this.events.emit(ProviderEvents.Error);
       throw e;
     }
   }

diff --git a/yarn.lock b/yarn.lock
@@ -1133,15 +1133,15 @@
   dependencies:
     "@octokit/openapi-types" "^18.0.0"
 
-"@openfeature/js-sdk@^1.3.3":
-  version "1.3.3"
-  resolved "https://registry.yarnpkg.com/@openfeature/js-sdk/-/js-sdk-1.3.3.tgz#84a5c1feaf41a1e7a4df7ce30c87aafb4fd9023b"
-  integrity "sha1-hKXB/q9Boeek33zjDIeq+0/ZAjs= sha512-VcI0Vy7pLi2V7JOUwgiuvaUDm54Ymkx5iq2ilPyTzaYItUaLnyfm6pG6kuxBkYsi7y5zp//086uiz17iBqEmLQ=="
-
-"@openfeature/web-sdk@^0.3.10-experimental":
-  version "0.3.10-experimental"
-  resolved "https://registry.yarnpkg.com/@openfeature/web-sdk/-/web-sdk-0.3.10-experimental.tgz#7e09225e67fd619ff2c8383c6563b40a59be8aa6"
-  integrity "sha1-fgkiXmf9YZ/yyDg8ZWO0Clm+iqY= sha512-WZp3MhhycHJFX9PM11quEcA8PEfI7PMkHYucvqxcbgYxpwF84T7KytppJ+Jkr6ErrwYbczWNAmlPOD4kEGZR0w=="
+"@openfeature/js-sdk@^1.4.2":
+  version "1.4.2"
+  resolved "https://registry.yarnpkg.com/@openfeature/js-sdk/-/js-sdk-1.4.2.tgz#09bcb5fdcdc94a654b5da432d663c08f25141426"
+  integrity sha512-Qgi26g3r7agzeY9MqFttH8xFlliWf+fQwp3Y0UxaBAdLG4AguCtM7LHWfAXJBh1mIdxoepx1KEf5xzhC2f/BEQ==
+
+"@openfeature/web-sdk@^0.4.0":
+  version "0.4.0"
+  resolved "https://registry.yarnpkg.com/@openfeature/web-sdk/-/web-sdk-0.4.0.tgz#1e12d5190a18479ba9cf253fe8b1e2843bda6553"
+  integrity sha512-k14SBiGCwPSQ9zhFfK2/oslUNrvfd/hleD2WfiKi69YDcWnsUqGeeXvvE4KI6FS54GJgXlNVpfqDQ4gUHbywHQ==
 
 "@parcel/[email protected]":
   version "2.0.4"