React improvements #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Billlynch
requested review from
andreas-karlsson,
tonyskn,
ammar1x and
varmenise
as code owners
Billlynch
force-pushed
the
react-improvments
branch
from
d01db57 to
2a2122b
Compare
Billlynch
force-pushed
the
react-improvments
branch
from
2a2122b to
ccfc24e
Compare
Billlynch
force-pushed
the
react-improvments
branch
from
ccfc24e to
5566977
Compare
andreas-karlsson
approved these changes
Oct 18, 2023
|
closes issue #11 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi There, I just made a Pull Request!
Currently we only trigger a re-render of the page on the first context change. This PR fixes that and allows for multiple context changes to happen, also simplifies the react implementation logic.
✔️ Checklist