Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(examples): on release please version update bump example deps #32

Merged
merged 2 commits into from
Oct 26, 2023

Conversation

Billlynch
Copy link
Collaborator

Hi There, I just made a Pull Request!

Added a git hook to bump the version number of the mono-repo packages in the example apps.
Added a checkmark to the PR template to remind people to use the example apps to verify changes.

When developing you will be using the current version number but the locally running example app will be using code built from the source in the mono-repo. Hence, when release please creates an update we are safe (assuming the changes have been tested in the example app, as they should be) to bump the version numbers in the example apps too using a hook.

✔️ Checklist

  • All tests are passing
  • Relevant documentation updated
  • linter/style run on changed files
  • Tests added for new functionality
  • Regression tests added for bug fixes
  • Tested in a corresponding example app

Copy link
Contributor

@andreas-karlsson andreas-karlsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Just a small comment, but it that was intentional I'm fine with how it is.

scripts/bump-example-deps.js Show resolved Hide resolved
@Billlynch Billlynch merged commit 8fe40e5 into main Oct 26, 2023
3 checks passed
@Billlynch Billlynch deleted the update_examples branch October 26, 2023 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants