Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Google Java Format 1.24.0 -> 1.25.0 #195

Closed

Conversation

Stephan202
Copy link
Contributor

@Stephan202 Stephan202 commented Nov 19, 2024

As of this release the plugin requires Java 17 or greater. Formatting
Java 11 source files is still supported.

See:

As of this release the plugin requires Java 17 or greater. Formatting
Java 11 source files is still supported.

See:
- https://github.com/google/google-java-format/releases/tag/v1.25.0
- google/google-java-format@v1.24.0...v1.25.0
@Stephan202 Stephan202 force-pushed the sschroevers/gjf-upgrade branch from 8cb0603 to 44e3263 Compare November 19, 2024 06:08
@Stephan202
Copy link
Contributor Author

The release notes on the tag haven't been populated yet at the time of writing, but this is a proper release containing several improvements to how text blocks are laid out.

As this release drops support for running the formatter with Java 11, perhaps a major release is in order.

One other thing to look into: I think that the fork_never_beforejdk16/pom.xml test is now never executed.

@Stephan202
Copy link
Contributor Author

I'll close this PR until I have some time to look into the required test changes; likely won't be today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant