Adding configurable BigQuery ProjectID on contrib jobs #3019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaximilianoFelice
requested review from
dlstadther,
honnix and
Tarrasch
as code owners
honnix
reviewed
Nov 26, 2020
| @@ -527,6 +527,12 @@ def allow_quoted_new_lines(self): | |||
| """ Indicates if BigQuery should allow quoted data sections that contain newline characters in a CSV file. The default value is false.""" | |||
| return False | |||
|
|
|||
| @property | |||
| def project_id(self): | |||
| """Project ID on which to run the BigQuery Job | |||
There was a problem hiding this comment.
Could you please add short description for the default value as well?
| @@ -610,6 +616,12 @@ def use_legacy_sql(self): | |||
| """ | |||
| return True | |||
|
|
|||
| @property | |||
| def project_id(self): | |||
| """Project ID on which to run the BigQuery Job | |||
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If closed, you may revisit when your time allows and reopen! Thank you for your contributions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding a way to configure BigQuery Project ID on both
BigQueryLoadTaskandBigQueryRunQueryTask.They are both added as properties of the class, keeping the same default as in previous versions.
Motivation and Context
BigQuery jobs can be run on different Project IDs than the ones configured by the output Dataset. This is especially useful for shared BigQuery Datasets, or when you usually need to defer the slot allocation between projects.
Have you tested this? If so, how?
I ran a local test using this feature.