Allowing user to load plugin with given sample rate and max block size #400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem This fixes issue spotify#399. Some plugins require the sample rate to the established already at init, where they perform sanity checks. To allow for more flexibility and for the sake of consistency, we can do the same for the block size. Solution Add sample_rate and maximum_block_size as optional input arguments to load_plugin(). The default values are kept to the ones that were previously hardcoded.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
This fixes issue #399. Some plugins require the sample rate to the established already at init, where they perform sanity checks. To allow for more flexibility and for the sake of consistency, we can do the same for the block size.
Solution
Add sample_rate and maximum_block_size as optional input arguments to load_plugin(). The default values are kept to the ones that were previously hardcoded.