Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
pedalboard supports python version >=3.8 ref.
However Ruff's latest 0.9.10's
target-version
is 3.9 by default ref . It's good to specify the minimum target version so that we will not have lint/format errors targeting 3.9.I confirmed recent CI runs with Ruff version 0.9.10 and it seems existing pytest codes have format errors.
https://github.com/spotify/pedalboard/actions/runs/13666616245/job/38209420452?pr=403
Changes
--target-version
option toruff format
andruff check
commands.ruff command help
ruff format
errors by addingtarget-version
options.Refs
Ruff 0.9.10 code related to default python-version:
It seems from 0.8.0, it's changed to use py39 ref
0.8.0 release Nov 22, 2024