Use avro builder API #5119
Merged
Use avro builder API #5119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RustedBones
commented
Dec 14, 2023
Comment on lines
+155
to
+157
| .sink(AvroBytesUtil.schema) | ||
| .asInstanceOf[BAvroIO.Sink[T]] | ||
| .withDatumWriterFactory(AvroBytesUtil.datumWriterFactory) |
There was a problem hiding this comment.
Small rewrite here to move away from deprecated sinkViaGenericRecords API
| private val byteField = schema.getField("bytes") | ||
|
|
||
| def datumWriterFactory[T: Coder]: DatumWriterFactory[T] = { | ||
| val bCoder = CoderMaterializer.beamWithDefault(Coder[T]) |
There was a problem hiding this comment.
Logic change here since we do not use the coder options for byte serialization. I think this cased of an issue when consuming data from PubSub, and tunring one Nullable, records could not be read.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5119 +/- ##
==========================================
- Coverage 63.36% 63.34% -0.02%
==========================================
Files 291 291
Lines 10842 10837 -5
Branches 745 753 +8
==========================================
- Hits 6870 6865 -5
Misses 3972 3972 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.