Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ack or fix deprecation warnings #5124

Merged
merged 1 commit into from
Dec 19, 2023
Merged

Ack or fix deprecation warnings #5124

merged 1 commit into from
Dec 19, 2023

Conversation

RustedBones
Copy link
Contributor

Fix deprecation warnings and acknowledge some that needs to be there until removed from upstream

Copy link

codecov bot commented Dec 15, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (9eed9a4) 63.33% compared to head (e7db16b) 63.35%.

Files Patch % Lines
...la/com/spotify/scio/bigquery/client/TableOps.scala 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5124      +/-   ##
==========================================
+ Coverage   63.33%   63.35%   +0.01%     
==========================================
  Files         291      291              
  Lines       10837    10840       +3     
  Branches      753      753              
==========================================
+ Hits         6864     6868       +4     
+ Misses       3973     3972       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RustedBones RustedBones merged commit 17619e9 into main Dec 19, 2023
11 checks passed
@RustedBones RustedBones deleted the deprecation-warnings branch December 19, 2023 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants