Improve accuracy of FixQuery rule #5438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5438 +/- ##
=======================================
Coverage 61.11% 61.11%
=======================================
Files 311 311
Lines 11075 11075
Branches 764 764
=======================================
+ Hits 6768 6769 +1
+ Misses 4307 4306 -1 ☔ View full report in Codecov by Sentry. |
kellen
approved these changes
Jul 24, 2024
RustedBones
approved these changes
Jul 25, 2024
RustedBones
reviewed
Jul 25, 2024
| Patch.replaceTree(t, q"$qual.queryRaw".syntax) | ||
| case t @ q"$qual.query" if isQuery(t) => | ||
| Patch.replaceTree(t, q"$qual.queryRaw".syntax) | ||
| case t @ q"$qual.query.format" if isQueryFormat(qual) => | ||
| Patch.replaceTree(t, q"$qual.queryRaw.format".syntax) |
There was a problem hiding this comment.
Shouldn't we try to directly use query(..) in that case ?
Suggested change
| Patch.replaceTree(t, q"$qual.queryRaw.format".syntax) | |
| Patch.replaceTree(t, q"$qual.query".syntax) |
There was a problem hiding this comment.
I simplified it to single case matching query directly 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The accuracy of FixQuery was not good when used on
@BigQueryType.frommacros. By matching on the<macro>.query.fromexpression, we can pick up on the macro class's ClassSignature, which includesHasQueryas a parent.