Skip to content
This repository has been archived by the owner on Apr 19, 2022. It is now read-only.

Add effective user parameter for command line use #219

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add effective user parameter for command line use #219

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion snakebite/commandlineparser.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,11 @@ class CommandLineParser(object):
'v': {"short": '-v',
"long": '--ver',
"help": 'Display snakebite version',
"type": int}
"type": int},
'u': {"short": '-u',
"long": '--user',
"help": 'Effective HDFS username',
"type": str}
}

SUB_OPTS = {'R': {"short": '-R',
Expand Down Expand Up @@ -443,6 +447,9 @@ def setup_client(self):
use_trash = self.args.usetrash and not self.args.skiptrash
else:
use_trash = self.args.usetrash
if 'user' in self.args:
self.user = self.args.user

self.client = HAClient(self.namenodes, use_trash, self.user, self.use_sasl, self.configs['hdfs_namenode_principal'],
self.configs['failover_max_attempts'], self.configs['client_retries'],
self.configs['client_sleep_base_millis'], self.configs['client_sleep_max_millis'],
Expand Down
8 changes: 7 additions & 1 deletion test/commandlineparser_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,13 +69,19 @@ def test_general_options(self):
output = parser.parse('--version 4 ls some_folder'.split())
self.assertEqual(output.version, 4)

output = parser.parse('-u someuser ls some_folder'.split())
self.assertEqual(output.user, 'someuser')
output = parser.parse('--user someuser ls some_folder'.split())
self.assertEqual(output.user, 'someuser')

#all options
output = parser.parse('-D -j -n namenode_fqdn -p 1234 -V 4 ls some_folder'.split())
output = parser.parse('-D -j -n namenode_fqdn -p 1234 -u someuser -V 4 ls some_folder'.split())
self.assertTrue(output.debug)
self.assertTrue(output.json)
self.assertEqual(output.namenode, "namenode_fqdn")
self.assertEqual(output.port, 1234)
self.assertEqual(output.version, 4)
self.assertEqual(output.user, 'someuser')

#options in illegal position
with self.assertRaises(SystemExit):
Expand Down