Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spring Cleaning - removes unused files/directories #413

Merged
merged 18 commits into from
May 12, 2023
Merged

Conversation

jeffrummel
Copy link
Contributor

No description provided.

@netlify
Copy link

netlify bot commented May 8, 2023

Deploy Preview for poor-richard-spotlightpa ready!

Name Link
🔨 Latest commit 771ae7b
🔍 Latest deploy log https://app.netlify.com/sites/poor-richard-spotlightpa/deploys/645d27e625faca0008b6cece
😎 Deploy Preview https://deploy-preview-413--poor-richard-spotlightpa.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@earthboundkid
Copy link
Contributor

I opened this branch and ran hugo --printUnusedTemplates:

WARN 2023/05/10 09:08:08 Template _default/about-statecollege.html is unused, source file /Users/adhoc/src/spl/poor-richard/layouts/_default/about-statecollege.html
WARN 2023/05/10 09:08:08 Template partials/blocks/default.html is unused, source file /Users/adhoc/src/spl/poor-richard/layouts/partials/blocks/default.html
WARN 2023/05/10 09:08:08 Template partials/blocks/donate-links.html is unused, source file /Users/adhoc/src/spl/poor-richard/layouts/partials/blocks/donate-links.html
WARN 2023/05/10 09:08:08 Template partials/helper/get-topics-by-name.html is unused, source file /Users/adhoc/src/spl/poor-richard/layouts/partials/helper/get-topics-by-name.html
WARN 2023/05/10 09:08:08 Template partials/js/view-trigger.html is unused, source file /Users/adhoc/src/spl/poor-richard/layouts/partials/js/view-trigger.html
WARN 2023/05/10 09:08:08 Template partials/tw/main-state-college.html is unused, source file /Users/adhoc/src/spl/poor-richard/layouts/partials/tw/main-state-college.html
WARN 2023/05/10 09:08:08 Template partials/tw/modal-newsletter.html is unused, source file /Users/adhoc/src/spl/poor-richard/layouts/partials/tw/modal-newsletter.html
WARN 2023/05/10 09:08:08 Template partials/tw/promo-text.html is unused, source file /Users/adhoc/src/spl/poor-richard/layouts/partials/tw/promo-text.html
WARN 2023/05/10 09:08:08 Template partials/tw/promo-topperarticle.html is unused, source file /Users/adhoc/src/spl/poor-richard/layouts/partials/tw/promo-topperarticle.html
WARN 2023/05/10 09:08:08 Template partials/tw/thumb-h-promo.html is unused, source file /Users/adhoc/src/spl/poor-richard/layouts/partials/tw/thumb-h-promo.html
WARN 2023/05/10 09:08:08 Template partials/tw/thumb-h-story-date-eyebrow.html is unused, source file /Users/adhoc/src/spl/poor-richard/layouts/partials/tw/thumb-h-story-date-eyebrow.html
WARN 2023/05/10 09:08:08 Template partials/tw/tnd-footer.html is unused, source file /Users/adhoc/src/spl/poor-richard/layouts/partials/tw/tnd-footer.html
WARN 2023/05/10 09:08:08 Template shortcodes/about/leaders-list.html is unused, source file /Users/adhoc/src/spl/poor-richard/layouts/shortcodes/about/leaders-list.html
WARN 2023/05/10 09:08:08 Template shortcodes/about/news-search.html is unused, source file /Users/adhoc/src/spl/poor-richard/layouts/shortcodes/about/news-search.html
WARN 2023/05/10 09:08:08 Template shortcodes/faq/a.html is unused, source file /Users/adhoc/src/spl/poor-richard/layouts/shortcodes/faq/a.html
WARN 2023/05/10 09:08:08 Template shortcodes/faq/meta.html is unused, source file /Users/adhoc/src/spl/poor-richard/layouts/shortcodes/faq/meta.html
WARN 2023/05/10 09:08:08 Template shortcodes/faq/q.html is unused, source file /Users/adhoc/src/spl/poor-richard/layouts/shortcodes/faq/q.html
WARN 2023/05/10 09:08:08 Template shortcodes/featured/donate-prefill-lg.html is unused, source file /Users/adhoc/src/spl/poor-richard/layouts/shortcodes/featured/donate-prefill-lg.html

I think these can just be removed:

  • _default/about-statecollege.html
  • partials/tw/main-state-college.html
  • partials/tw/modal-newsletter.html
  • partials/tw/thumb-h-story-date-eyebrow.html
  • partials/helper/get-topics-by-name.html
  • partials/tw/tnd-footer.html
  • shortcodes/about/leaders-list.html
  • shortcodes/about/news-search.html

These are false positives that are still in use but waiting for something to be turned on:

  • partials/blocks/default.html
  • partials/tw/promo-text.html
  • partials/tw/promo-topperarticle.html
  • partials/tw/thumb-h-promo.html

This one I think should be reworked and brought back, since it is useful:

  • partials/js/view-trigger.html

We're not using these now, but we should probably leave them in case we want to use them later:

  • shortcodes/faq/a.html
  • shortcodes/faq/meta.html
  • shortcodes/faq/q.html
  • shortcodes/featured/donate-prefill-lg.html

        deleted:    layouts/_default/about-statecollege.html
        deleted:    layouts/partials/helper/get-topics-by-name.html
        deleted:    layouts/partials/tw/main-state-college.html
        deleted:    layouts/partials/tw/modal-newsletter.html
        deleted:    layouts/partials/tw/thumb-h-story-date-eyebrow.html
        deleted:    layouts/partials/tw/tnd-footer.html
        deleted:    layouts/shortcodes/about/leaders-list.html
        deleted:    layouts/shortcodes/about/news-search.html
-- #413 (comment)
@jeffrummel jeffrummel marked this pull request as ready for review May 11, 2023 14:37
@jeffrummel jeffrummel merged commit fdb33fc into master May 12, 2023
@jeffrummel jeffrummel deleted the jr/file-clean branch May 12, 2023 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants