Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add short_grass #101

Merged
merged 4 commits into from
Jan 6, 2024
Merged

Conversation

Netherwhal
Copy link
Contributor

@Netherwhal Netherwhal commented Dec 30, 2023

grass was renamed to short_grass in 1.20.4 (https://minecraft.wiki/w/Short_Grass#Data_history) - there are more blocks, but they are not yet officially released.

I also added some automation to the script especially for macOS users, as I keep forgetting how to use the script :P

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although this is a good idea, the implementation of this script will make it harder to run on non-mac platforms. I will rework it to keep all of the code but make it more modular.

@spoutn1k
Copy link
Owner

spoutn1k commented Jan 5, 2024

This works exactly like your script on my mac but will not fail on Linux. Please check on your side and I'll merge if no errors are reported !

@Netherwhal
Copy link
Contributor Author

Perfect, thanks @spoutn1k

@spoutn1k spoutn1k merged commit eb63c00 into spoutn1k:NBT19133 Jan 6, 2024
5 checks passed
@pedter pedter mentioned this pull request Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants