Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Constrain CQP subqueries to span match #334

Merged
merged 2 commits into from
Jan 31, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,17 @@

## [9.5.1-dev]

### Changed

- Logos with taglines

### Fixed

- Improve UX for "in order" option [#335](https://github.com/spraakbanken/korp-frontend/issues/335)
- Unnecessary scrollbars in the corpus selector info panel [#333](https://github.com/spraakbanken/korp-frontend/issues/333)
- Bug with undefined `arguments`
- On repetition error (all tokens repeat from 0), restore red outline for input
- Use `<match>` to constraint CQP subqueries (from statistics rows etc)

## [9.5.0] - 2023-01-22

Expand Down
2 changes: 1 addition & 1 deletion app/config/statistics_config.js
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ let getCqp = function (hitValues, ignoreCase) {
}
tokens.push("[" + andExpr.join(" & ") + "]")
}
return tokens.join(" ")
return `<match> ${tokens.join(" ")} []* </match>`
}

let reduceCqp = function (type, tokens, ignoreCase) {
Expand Down
188 changes: 188 additions & 0 deletions app/img/korp_slogan.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
183 changes: 183 additions & 0 deletions app/img/korp_slogan_en.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
213 changes: 213 additions & 0 deletions app/img/sprakbanken_text_slogan.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
204 changes: 204 additions & 0 deletions app/img/sprakbanken_text_slogan_en.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
28 changes: 18 additions & 10 deletions app/scripts/components/header.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
/** @format */
import korpLogo from "../../img/korp.svg"
import sbxLogo from "../../img/sprakbanken_text.svg"
import korpLogo from "../../img/korp_slogan.svg"
import korpLogoEn from "../../img/korp_slogan_en.svg"
import sbxLogo from "../../img/sprakbanken_text_slogan.svg"
import sbxLogoEn from "../../img/sprakbanken_text_slogan_en.svg"
import guLogo from "../../img/gu_logo_sv_head.svg"

let html = String.raw
Expand Down Expand Up @@ -99,9 +101,10 @@ export const headerComponent = {
<!-- TODO too many divs -->
</div>

<div class="flex justify-between items-end gap-3 h-24 pb-1 mb-5 mt-2 px-3" id="header_left">
<div class="flex justify-between items-end gap-3 my-3 px-3" id="header_left">
<a class="shrink-0 relative ml-4 pl-0.5" ng-click="$ctrl.logoClick()">
<img class="-mb-5" src="${korpLogo}" height="300" width="300" />
<img ng-if="$root.lang == 'swe'" src="${korpLogo}" height="300" width="300" />
<img ng-if="$root.lang != 'swe'" src="${korpLogoEn}" height="300" width="300" />
</a>
<div id="labs_logo">
<svg
Expand All @@ -124,15 +127,20 @@ export const headerComponent = {
</svg>
</div>

<div class="grow lg_hidden"></div>
<div class="grow min-[1150px]_hidden"></div>
<corpus-chooser></corpus-chooser>
<div class="grow hidden lg_block"></div>

<a class="hidden lg_block h-12 shrink" href="https://spraakbanken.gu.se" target="_blank">
<img src="${sbxLogo}" class="h-full" />
<div class="grow hidden min-[1150px]_block"></div>

<a
class="hidden min-[1150px]_flex h-20 shrink flex-col justify-end"
href="https://spraakbanken.gu.se/"
target="_blank"
>
<img ng-if="$root.lang == 'swe'" src="${sbxLogo}" />
<img ng-if="$root.lang != 'swe'" src="${sbxLogoEn}" />
</a>

<a class="hidden xl_block shrink-0 h-32 pt-1 -mb-6" href="https://gu.se" target="_blank">
<a class="hidden xl_block shrink-0 h-32 -mt-2" href="https://gu.se/" target="_blank">
<img src="${guLogo}" class="h-full" />
</a>
</div>
Expand Down
Loading