Adds store pdf as file feature. #80
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
March 27, 2015 18:05
The order can now render itself to pdf.
The controller now tells the order to render itself as pdf and to store it, if enabled.
|
Ah, dang! I broke the |
Like before: it sets the invoice number to next incremential value, if enabled.
|
Ok, have to check the tests on travis. They pass locally. 😞 |
|
Probably because travis isn't giving you file system access |
|
@JDutil I fixed the specs |
tvdeyen
pushed a commit
that referenced
this pull request
Apr 9, 2015
Remove selenium support and update poltergeist. Adds new settings store_pdf and storage_path Adds pdf file generation to order model. The order can now render itself to pdf. Delegate order controller show :pdf action to order. The controller now tells the order to render itself as pdf and to store it, if enabled. Fix pdf templates. Add javascript injection to install generator. Mention store pdf feature in readme Updates invoice number on pdf render in controller. Like before: it sets the invoice number to next incremential value, if enabled. Stub configuration for more reliable tests Fixes #80
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces new settings
store_pdf(disabled by default) andstorage_paththat allow to store the rendered pdf template to disk. These files can then be i.e. attached to emails.Also refactors some tests and moves lots of code into the order model, away from the orders controller.
Refs #60