feature/qr_for_display: Add QR code image for displays #9
Conversation
| module Spree | ||
| module Api | ||
| module V2 | ||
| class ProductsController < ::Spree::Api::V2::BaseController |
There was a problem hiding this comment.
why do we override products controller in kiosk app?
There was a problem hiding this comment.
It is for returning the products added to the display.
There was a problem hiding this comment.
i dont get it.. we can fecth display products from display show api only with include paramaters.. instead of over ride in product controller
| @@ -2,7 +2,7 @@ module Spree | |||
| module Api | |||
| module V2 | |||
| class DisplaySerializer < BaseSerializer | |||
| attributes :id, :name, :screen_size, :orientation, :vendor_id, :display_type, :products_array, :active | |||
| attributes :id, :name, :screen_size, :orientation, :vendor_id, :display_type, :products_array, :active, :qr_code_url | |||
There was a problem hiding this comment.
why do we have qr code url?
There was a problem hiding this comment.
this is also something generatable like we did on product right?
There was a problem hiding this comment.
I am following the similar pattern for attribute used in the display product model and the qr is also generatable as in product.
There was a problem hiding this comment.
maile product ma pani url hatauna ra dynamic ganerate garna bhaneko thyea..why do we have url in db?
* fixed QR url issue * fixed QR url issue * fixed QR url --------- Co-authored-by: Sushil Subedi <[email protected]>
No description provided.