Skip to content
This repository has been archived by the owner on Apr 5, 2022. It is now read-only.

Facebook Marketing API implementation (ads management + ads insights) #155

Open
wants to merge 30 commits into
base: master
Choose a base branch
from

Conversation

sebast26
Copy link

Hello,
I started some work towards implementing Marketing API in Spring Social Facebook. This is the first part. It's adding support for account operations. I also just wanted to see if you have some issues with my way of integrating existing code with new Marketing API implementation.

I formatted code using your settings. I signed the individual contributor agreement.

@liu-shiyuan
Copy link

Hi,
while create a adSet, a FacebookApiException occured, which said that 'When creating an ad set within a campaign using this objective, a promoted object must be specified.'. I think that u missing setting the Promoted Object, check this for reference: https://developers.facebook.com/docs/marketing-api/adset/v2.3

@liu-shiyuan
Copy link

Hi,
I like your work and looking forward to more your splendid implements of Marketing API, I wonder that whether you have a schedule for the following work.

@sebast26
Copy link
Author

sebast26 commented Jul 6, 2015

Hi,
first of all thank you for checking out my code. Secondly, you are right about the promoted_object field missing in ad set. I was focused on targeting field and missed the required field (in most cases I guess). I will add it in a moment.

In case of your second question: there is no schedule. As you may see I have finished core functionality (I have added ads support). I need to contact with Craig Walls and ask him to validate my work. In future I plan to add/refactor some things.. so stay in touch and please test this code ;-)

@sebast26 sebast26 changed the title Marketing API: Ads support for account operations and account insights. Facebook Marketing API implementation (ads management + ads insights) Jul 6, 2015
@nemccarthy
Copy link

+1 for this

@pivotal-issuemaster
Copy link

@sebast26 Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@pivotal-issuemaster
Copy link

@sebast26 Thank you for signing the Contributor License Agreement!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants