This repository has been archived by the owner on Apr 5, 2022. It is now read-only.
SocialContextOperations#getAllMutualFriends: Fix NPE and add picture as extra data #220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…be null for User Context - All Mutual friends. According the facebook graph API documentation: The ID will be returned for a mutual friend only if the given user has installed your app and granted the user_friends permission
… is returned from facebook response.
Sample Format:
{
"id": null,
"name": "Non App user name",
"extraData": {
"id": "picture",
"value": "https://scontent.xx.fbcdn.net/v/t1.0-1/c15.0.50.50/p50x50/1379841_10150004552801901_469209496895221757_n.jpg?oh=7d1a30477a7ac57749e72821136a7090&oe=5865EA33"
}
}
troig
changed the title
|
@troig Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
|
@troig Thank you for signing the Contributor License Agreement! |
|
@troig : I'm ready to merge this, but would rather the PR included tests (or changes to existing tests) that verify that the PR does what it claims. Without tests, the PR review process requires much more time. May I request that you add such tests? |
|
@habuma: Sure, let me a few days to have it a look. Thanks |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#219