This repository has been archived by the owner on Apr 5, 2022. It is now read-only.
set missing username in UserProfile #55
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because Linkedin api does not supply an username from their api, linkedinAdoper does not set one, but leaving username as null in UserProfile makes other dependent framework like spring-social-security to break while persisting. It's good to set 'default-username' as linkedin id, as it's the only unique identity we get from linkedin.
spring-builds
pushed a commit
that referenced
this pull request
May 10, 2017
Handle new HTTP status code (429) for rate limiting. SOCIALTW-53
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because Linkedin api does not supply an username from their api, linkedinAdoper does not set one, but leaving username as null in UserProfile makes other dependent framework like spring-social-security to break while persisting. It's good to set 'default-username' as linkedin id, as it's the only unique identity we get from linkedin.