Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to Prometheus 1.x client #6068

Open
onobc opened this issue Nov 13, 2024 · 0 comments
Open

Update to Prometheus 1.x client #6068

onobc opened this issue Nov 13, 2024 · 0 comments
Assignees
@onobc
Labels
area/dependencies Belongs project dependencies area/observability
Milestone
3.0.x

Comments

@onobc
Copy link
Contributor

onobc commented Nov 13, 2024

We are currently using the 0.x Prometheus client (simple client). We want to move up to the 1.x client as Boot will remove the support for simple client auto-configuration in SB 3.5.x

Note

The update to 1.x client changes output of metrics and is likely to break our dashboard.
Pay attention to: https://github.com/micrometer-metrics/micrometer/wiki/1.13-Migration-Guide
@onobc onobc added area/observability area/dependencies Belongs project dependencies labels Nov 13, 2024
@onobc onobc added this to the 3.0.x milestone Nov 13, 2024
@onobc onobc mentioned this issue Nov 13, 2024
Open
@onobc onobc mentioned this issue Dec 13, 2024
Open
onobc added a commit to onobc/spring-cloud-dataflow that referenced this issue Dec 13, 2024
@onobc
Use new Prometheus Rsocket client
c7763cc 
Replaces the `micrometer.io:micrometer-registry-prometheus-simpleclient`
with `micrometer.io:micrometer-registry-prometheus`.

Also updates the Prometheus Rsocket version from `2.0.0-M3`
to `2.0.0-SNAPSHOT` as the M3 has a bug. Will update to M4 when available.

See spring-cloud#6068
See spring-cloud#6069
@onobc onobc mentioned this issue Dec 13, 2024
Merged
onobc added a commit to onobc/spring-cloud-dataflow that referenced this issue Dec 13, 2024
@onobc
Updates the Prometheus Rsocket version to 2.0.0-M4
3e46431 
See spring-cloud#6068
See spring-cloud#6069
onobc added a commit to onobc/spring-cloud-dataflow that referenced this issue Dec 13, 2024
@onobc
Use new Prometheus client (1.x)
74a2ce5 
Replaces the `micrometer.io:micrometer-registry-prometheus-simpleclient`
with `micrometer.io:micrometer-registry-prometheus`.

Also updates the Prometheus RSocket version from `2.0.0-M3`
to `2.0.0-M4`.

See spring-cloud#6068
See spring-cloud#6069
onobc added a commit that referenced this issue Dec 19, 2024
@onobc
Use new Prometheus client (1.x) (#6090)
0931f1e 
Replaces the `micrometer.io:micrometer-registry-prometheus-simpleclient`
with `micrometer.io:micrometer-registry-prometheus`.

Also updates the Prometheus RSocket version from `2.0.0-M3`
to `2.0.0-M4`.

See #6068
See #6069
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@onobc onobc

Labels
area/dependencies Belongs project dependencies area/observability
Projects
None yet
Milestone
3.0.x
Development

No branches or pull requests
1 participant
@onobc