separate surefire/failsafe directory for report on each matrix step #1463
Conversation
| @@ -35,29 +35,6 @@ | |||
|
|
|||
| </build> | |||
|
|
|||
| <profiles> | |||
There was a problem hiding this comment.
so this solution did not help :( I tested it against a few branches that I maintain and I still get things to block on the failsafe/surefire plugins sometimes. As such, I am dropping the idea. There is good news though...
| -e clean install \ | ||
| -P 'sonar, run-on-github-actions' -nsu --batch-mode \ |
There was a problem hiding this comment.
drop the profile since we don't need it anymore
| -e clean install \ | ||
| -P 'sonar, run-on-github-actions' -nsu --batch-mode \ |
There was a problem hiding this comment.
drop the profile since we do not need it anymore
| <!-- Dependency Versions --> | ||
| <mockito-inline.version>4.8.1</mockito-inline.version> | ||
| <spring-cloud-commons.version>4.0.5-SNAPSHOT</spring-cloud-commons.version> | ||
| <spring-cloud-config.version>4.0.5-SNAPSHOT</spring-cloud-config.version> | ||
| <spring-cloud-bus.version>4.0.1</spring-cloud-bus.version> | ||
| <spring-cloud-contract.version>4.0.5-SNAPSHOT</spring-cloud-contract.version> | ||
|
|
||
| <maven-surefire-plugin.version>3.1.0</maven-surefire-plugin.version> |
There was a problem hiding this comment.
I honestly don't know why we have this one here, I want to simplify as much as possible related to surefire/failsafe - just remove it, build passes just fine without it
| </plugin> | ||
|
|
||
| <plugin> | ||
| <groupId>org.apache.maven.plugins</groupId> |
There was a problem hiding this comment.
my previous observation that the hangs in the builds are related to surefie/failsafe still stands, this still happens.
In the initial approach, I hoped that upgrading the plugins will solve this problem - and I was wrong. My builds in some other branches proved this.
The other observations I made looking at the failures, is that all of them hang somewhere around logs like these (not verbatim):
will use .../surefire-reports directory for saving test results
So may be this is related to a folder/file being accessed from various matrix steps at the same time. At least, this is my best guess. If that is the case, what if we save the reports in folder structure like so:
surefire-reports/<CURRENT_INDEX>...
this way, may be they will not step on each others feet. Semantically, for our builds, this is irrelevant, we only need those reports for when we find out the test times, but out searches are against an entire directory that comes before surefire-reports, so the searches still work, as seen from the logs:
searching for filename: org.springframework.cloud.kubernetes.client.discovery.it.KubernetesClientDiscoveryClientIT.txt
found file: ./spring-cloud-kubernetes-integration-tests/spring-cloud-kubernetes-client-discovery-it/target/failsafe-reports/2/org.springframework.cloud.kubernetes.client.discovery.it.KubernetesClientDiscoveryClientIT.txt
There was a problem hiding this comment.
this solution makes the branches that I maintain to pass on all of them (and it was not the case before)
wind57
changed the title
|
@ryanjbaxter this is ready to be looked, relevant comment left everywhere. Our current |
| @@ -62,15 +62,14 @@ | |||
| </scm> | |||
|
|
|||
| <properties> | |||
| <CURRENT_INSTANCE>one</CURRENT_INSTANCE> | |||
There was a problem hiding this comment.
Can you add a comment here about what this is used for?
No description provided.